From: Greg KH <gregkh@linuxfoundation.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: rafael@kernel.org, ojeda@kernel.org, boqun.feng@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
david.m.ertman@intel.com, ira.weiny@intel.com, leon@kernel.org,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 4/5] rust: usb: use "kernel vertical" style for imports
Date: Wed, 7 Jan 2026 16:09:26 +0100 [thread overview]
Message-ID: <2026010718-ensnare-epidermal-19ff@gregkh> (raw)
In-Reply-To: <DFHR4WMDV5U7.KFFXHIYXI6M3@kernel.org>
On Tue, Jan 06, 2026 at 08:26:40PM +0100, Danilo Krummrich wrote:
> On Mon Jan 5, 2026 at 3:19 PM CET, Danilo Krummrich wrote:
> > Convert all imports to use "kernel vertical" style.
> >
> > With this, subsequent patches neither introduce unrelated changes nor
> > leave an inconsistent import pattern.
> >
> > While at it, drop unnecessary imports covered by prelude::*.
> >
> > Link: https://docs.kernel.org/rust/coding-guidelines.html#imports
> > Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> > ---
> > @Greg: If you agree I will take this through the driver-core tree. I will have
> > driver-core patches building on top of this.
>
> Nevermind, I don't need it in the driver-core tree after all. :)
Ok, I'll take it through the usb one now, thanks.
greg k-h
next prev parent reply other threads:[~2026-01-07 15:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 14:19 [PATCH 1/5] rust: auxiliary: use "kernel vertical" style for imports Danilo Krummrich
2026-01-05 14:19 ` [PATCH 2/5] rust: platform: " Danilo Krummrich
2026-01-07 15:09 ` Greg KH
2026-01-07 21:29 ` Danilo Krummrich
2026-01-05 14:19 ` [PATCH 3/5] rust: driver-core: " Danilo Krummrich
2026-01-07 15:09 ` Greg KH
2026-01-07 21:30 ` Danilo Krummrich
2026-01-05 14:19 ` [PATCH 4/5] rust: usb: " Danilo Krummrich
2026-01-05 19:36 ` Daniel Almeida
2026-01-05 23:41 ` Miguel Ojeda
2026-01-06 19:26 ` Danilo Krummrich
2026-01-07 15:09 ` Greg KH [this message]
2026-01-05 14:19 ` [PATCH 5/5] rust: faux: " Danilo Krummrich
2026-01-07 15:09 ` Greg KH
2026-01-07 21:30 ` Danilo Krummrich
2026-01-07 15:09 ` [PATCH 1/5] rust: auxiliary: " Greg KH
2026-01-07 21:29 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026010718-ensnare-epidermal-19ff@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=david.m.ertman@intel.com \
--cc=gary@garyguo.net \
--cc=ira.weiny@intel.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox