From: "Onur Özkan" <work@onurozkan.dev>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Will Deacon" <will@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Gary Guo" <gary@garyguo.net>, "Miguel Ojeda" <ojeda@kernel.org>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] scripts: atomic: check for argument in gen-rust-atomic-helpers.sh
Date: Thu, 8 Jan 2026 16:54:53 +0300 [thread overview]
Message-ID: <20260108165453.54679b9a@nimda> (raw)
In-Reply-To: <20260108-gen-rust-atomic-helpers-msg-v1-1-d895a9667148@google.com>
On Thu, 08 Jan 2026 13:08:57 +0000
Alice Ryhl <aliceryhl@google.com> wrote:
> Currently, running `scripts/atomic/gen-rust-atomic-helpers.sh` without
> arguments results in a broken header file and grep errors:
>
> $ scripts/atomic/gen-rust-atomic-helpers.sh
> grep: : No such file or directory
> grep: : No such file or directory
>
> The user may do this to re-generate the Rust helpers, not realizing
> that they called the wrong script [1]. In this scenario, point the
> user to `scripts/atomic/gen-atomics.sh` instead of failing in a
> cryptic way.
>
> $ scripts/atomic/gen-rust-atomic-helpers.sh
> call scripts/atomic/gen-atomics.sh instead
>
> Link:
> https://lore.kernel.org/r/CAH5fLghgm2pPdKen2rv6MeSXAYG_j_eCqvM0b=VbTbUM9eswKg@mail.gmail.com
> Signed-off-by: Alice Ryhl <aliceryhl@google.com> ---
> scripts/atomic/gen-rust-atomic-helpers.sh | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/scripts/atomic/gen-rust-atomic-helpers.sh
> b/scripts/atomic/gen-rust-atomic-helpers.sh index
> 45b1e100ed7c63108ee6cb07e48a17668f860d47..1c76f8ae731de9ac069d489469b0383f256b1539
> 100755 --- a/scripts/atomic/gen-rust-atomic-helpers.sh +++
> b/scripts/atomic/gen-rust-atomic-helpers.sh @@ -5,6 +5,11 @@
> ATOMICDIR=$(dirname $0)
> . ${ATOMICDIR}/atomic-tbl.sh
>
> +if [ -z "$1" ]; then
> + echo "call scripts/atomic/gen-atomics.sh instead" >&2
> + exit 1
> +fi
> +
> #gen_proto_order_variant(meta, pfx, name, sfx, order, atomic, int,
> arg...) gen_proto_order_variant()
> {
>
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20260108-gen-rust-atomic-helpers-msg-3943461645fb
>
> Best regards,
Makes sense.
Reviewed-by: Onur Özkan <work@onurozkan.dev>
thanks,
Onur
prev parent reply other threads:[~2026-01-08 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 13:08 [PATCH] scripts: atomic: check for argument in gen-rust-atomic-helpers.sh Alice Ryhl
2026-01-08 13:54 ` Onur Özkan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108165453.54679b9a@nimda \
--to=work@onurozkan.dev \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mark.rutland@arm.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox