From: Timur Tabi <ttabi@nvidia.com>
To: Matthew Maurer <mmaurer@google.com>,
Danilo Krummrich <dakr@kernel.org>, Gary Guo <gary@garyguo.net>,
John Hubbard <jhubbard@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
Alexandre Courbot <acourbot@nvidia.com>,
<rust-for-linux@vger.kernel.org>, <nouveau@lists.freedesktop.org>
Subject: [PATCH v4 6/9] rust: debugfs: wrap Entry in an enum to prep for LookupDir
Date: Tue, 13 Jan 2026 16:54:05 -0600 [thread overview]
Message-ID: <20260113225408.671252-7-ttabi@nvidia.com> (raw)
In-Reply-To: <20260113225408.671252-1-ttabi@nvidia.com>
To prepare the Entry struct for adding support for LookupDir, create a
wrapper enum DynParent. For now, it only holds an Arc<Entry>.
Signed-off-by: Timur Tabi <ttabi@nvidia.com>
---
rust/kernel/debugfs/entry.rs | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/rust/kernel/debugfs/entry.rs b/rust/kernel/debugfs/entry.rs
index 706cb7f73d6c..3152e4f96219 100644
--- a/rust/kernel/debugfs/entry.rs
+++ b/rust/kernel/debugfs/entry.rs
@@ -7,6 +7,16 @@
use crate::sync::Arc;
use core::marker::PhantomData;
+/// Type-erased parent that keeps either an `Entry` or `LookupEntry` alive.
+///
+/// This allows an `Entry` to have either type of parent while maintaining proper
+/// lifetime management. The parent is kept alive via `Arc` reference counting.
+#[allow(dead_code)]
+pub(crate) enum DynParent {
+ /// Parent is an owned `Entry` (will be removed on drop).
+ Entry(Arc<Entry<'static>>),
+}
+
/// Owning handle to a DebugFS entry.
///
/// # Invariants
@@ -15,7 +25,7 @@
pub(crate) struct Entry<'a> {
entry: *mut bindings::dentry,
// If we were created with an owning parent, this is the keep-alive
- _parent: Option<Arc<Entry<'static>>>,
+ _parent: Option<DynParent>,
// If we were created with a non-owning parent, this prevents us from outliving it
_phantom: PhantomData<&'a ()>,
}
@@ -41,7 +51,7 @@ pub(crate) fn dynamic_dir(name: &CStr, parent: Option<Arc<Self>>) -> Self {
Entry {
entry,
- _parent: parent,
+ _parent: parent.map(DynParent::Entry),
_phantom: PhantomData,
}
}
@@ -74,7 +84,7 @@ pub(crate) unsafe fn dynamic_file<T>(
Entry {
entry,
- _parent: Some(parent),
+ _parent: Some(DynParent::Entry(parent)),
_phantom: PhantomData,
}
}
--
2.52.0
next prev parent reply other threads:[~2026-01-13 22:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 22:53 [PATCH v4 0/9] gpu: nova-core: expose the logging buffers via debugfs Timur Tabi
2026-01-13 22:54 ` [PATCH v4 1/9] rust: pci: add PCI device name method Timur Tabi
2026-01-13 22:54 ` [PATCH v4 2/9] gpu: nova-core: implement BinaryWriter for LogBuffer Timur Tabi
2026-01-13 22:54 ` [PATCH v4 3/9] gpu: nova-core: Replace module_pci_driver! with explicit module init Timur Tabi
2026-01-13 22:54 ` [PATCH v4 4/9] gpu: nova-core: use pin projection in method boot() Timur Tabi
2026-01-13 22:54 ` [PATCH v4 5/9] rust: debugfs: implement Directory trait for Dir Timur Tabi
2026-01-15 17:27 ` kernel test robot
2026-01-13 22:54 ` Timur Tabi [this message]
2026-01-13 22:54 ` [PATCH v4 7/9] rust: debugfs: add LookupDir Timur Tabi
2026-01-13 22:54 ` [PATCH v4 8/9] gpu: nova-core: create debugfs root when driver loads Timur Tabi
2026-01-13 22:54 ` [PATCH v4 9/9] gpu: nova-core: create GSP-RM logging buffers debugfs entries Timur Tabi
2026-01-13 23:11 ` [PATCH v4 0/9] gpu: nova-core: expose the logging buffers via debugfs Danilo Krummrich
2026-01-13 23:26 ` Timur Tabi
2026-01-13 23:50 ` Danilo Krummrich
2026-01-13 23:59 ` Timur Tabi
2026-01-14 1:09 ` Gary Guo
2026-01-14 11:17 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260113225408.671252-7-ttabi@nvidia.com \
--to=ttabi@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=mmaurer@google.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox