From: Timur Tabi <ttabi@nvidia.com>
To: Matthew Maurer <mmaurer@google.com>,
Danilo Krummrich <dakr@kernel.org>, Gary Guo <gary@garyguo.net>,
John Hubbard <jhubbard@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
Alexandre Courbot <acourbot@nvidia.com>,
<nouveau@lists.freedesktop.org>, <rust-for-linux@vger.kernel.org>
Subject: [PATCH v5 2/8] rust: debugfs: add Dir::empty() for conditional debugfs usage
Date: Fri, 16 Jan 2026 15:49:53 -0600 [thread overview]
Message-ID: <20260116214959.641032-3-ttabi@nvidia.com> (raw)
In-Reply-To: <20260116214959.641032-1-ttabi@nvidia.com>
Add Dir::empty() which returns a &'static reference to a no-op Dir.
All file and subdirectory operations on this directory silently succeed
without creating actual filesystem entries.
This enables callers to use a single code path regardless of whether
debugfs is available at runtime. For example:
let dir = optional_debugfs_root.unwrap_or_else(|| Dir::empty());
dir.scope(data, name, |d, s| { ... })
The returned reference has 'static lifetime, allowing initializers
returned by scope() to be used outside the immediate scope where the
Dir reference was obtained.
Signed-off-by: Timur Tabi <ttabi@nvidia.com>
---
rust/kernel/debugfs.rs | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/rust/kernel/debugfs.rs b/rust/kernel/debugfs.rs
index facad81e8290..44ff2b37786a 100644
--- a/rust/kernel/debugfs.rs
+++ b/rust/kernel/debugfs.rs
@@ -110,6 +110,24 @@ pub fn new(name: &CStr) -> Self {
Dir::create(name, None)
}
+ /// Returns a reference to a static no-op directory that doesn't create any debugfs entries.
+ ///
+ /// All file and subdirectory creation operations on this directory will silently succeed
+ /// without creating actual filesystem entries. This is useful when you want to conditionally
+ /// enable debugfs but use the same code path regardless.
+ pub fn empty() -> &'static Self {
+ #[cfg(CONFIG_DEBUG_FS)]
+ {
+ static EMPTY: Dir = Dir(None);
+ &EMPTY
+ }
+ #[cfg(not(CONFIG_DEBUG_FS))]
+ {
+ static EMPTY: Dir = Dir();
+ &EMPTY
+ }
+ }
+
/// Creates a subdirectory within this directory.
///
/// # Examples
--
2.52.0
next prev parent reply other threads:[~2026-01-16 21:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 21:49 [PATCH v5 0/8] gpu: nova-core: expose the logging buffers via debugfs Timur Tabi
2026-01-16 21:49 ` [PATCH v5 1/8] rust: pci: add device name method Timur Tabi
2026-01-17 11:09 ` Danilo Krummrich
2026-01-27 21:04 ` Timur Tabi
2026-01-27 21:07 ` Danilo Krummrich
2026-01-16 21:49 ` Timur Tabi [this message]
2026-01-19 12:08 ` [PATCH v5 2/8] rust: debugfs: add Dir::empty() for conditional debugfs usage Gary Guo
2026-01-20 17:54 ` Matthew Maurer
2026-01-20 18:19 ` Danilo Krummrich
2026-01-16 21:49 ` [PATCH v5 3/8] rust: uaccess: add UserSliceWriter::write_buffer() for raw pointer writes Timur Tabi
2026-01-17 11:18 ` Danilo Krummrich
2026-01-17 11:19 ` Danilo Krummrich
2026-01-17 13:23 ` Alice Ryhl
2026-01-17 14:23 ` Alice Ryhl
2026-01-17 14:35 ` Danilo Krummrich
2026-01-19 12:13 ` Gary Guo
2026-01-19 12:38 ` Danilo Krummrich
2026-01-16 21:49 ` [PATCH v5 4/8] gpu: nova-core: implement BinaryWriter for LogBuffer Timur Tabi
2026-01-17 11:22 ` Danilo Krummrich
2026-01-19 12:17 ` Gary Guo
2026-01-28 20:20 ` Timur Tabi
2026-01-16 21:49 ` [PATCH v5 5/8] gpu: nova-core: Replace module_pci_driver! with explicit module init Timur Tabi
2026-01-17 11:24 ` Danilo Krummrich
2026-01-28 20:52 ` Timur Tabi
2026-01-16 21:49 ` [PATCH v5 6/8] gpu: nova-core: use pin projection in method boot() Timur Tabi
2026-01-16 21:49 ` [PATCH v5 7/8] gpu: nova-core: create debugfs root in module init Timur Tabi
2026-01-17 12:18 ` Danilo Krummrich
2026-01-17 12:29 ` Danilo Krummrich
2026-01-17 20:58 ` Timur Tabi
2026-01-17 21:35 ` Danilo Krummrich
2026-01-17 21:52 ` Timur Tabi
2026-01-17 22:00 ` Danilo Krummrich
2026-01-16 21:49 ` [PATCH v5 8/8] gpu: nova-core: create GSP-RM logging buffers debugfs entries Timur Tabi
2026-01-17 12:21 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116214959.641032-3-ttabi@nvidia.com \
--to=ttabi@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=mmaurer@google.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox