From: Timur Tabi <ttabi@nvidia.com>
To: Matthew Maurer <mmaurer@google.com>,
Danilo Krummrich <dakr@kernel.org>, Gary Guo <gary@garyguo.net>,
John Hubbard <jhubbard@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
Alexandre Courbot <acourbot@nvidia.com>,
<nouveau@lists.freedesktop.org>, <rust-for-linux@vger.kernel.org>
Subject: [PATCH v5 3/8] rust: uaccess: add UserSliceWriter::write_buffer() for raw pointer writes
Date: Fri, 16 Jan 2026 15:49:54 -0600 [thread overview]
Message-ID: <20260116214959.641032-4-ttabi@nvidia.com> (raw)
In-Reply-To: <20260116214959.641032-1-ttabi@nvidia.com>
Add a new method to UserSliceWriter that copies data from a raw kernel
pointer to userspace, without requiring a Rust slice reference.
The method takes:
- data: raw pointer to the source buffer
- len: total size of the source buffer (for bounds checking)
- offset: byte offset into the source buffer to start copying from
- count: number of bytes to copy
The method is marked unsafe because the caller must ensure the pointer
is valid for the specified length and that the memory is not mutated
during the call.
Signed-off-by: Timur Tabi <ttabi@nvidia.com>
---
rust/kernel/uaccess.rs | 50 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/rust/kernel/uaccess.rs b/rust/kernel/uaccess.rs
index f989539a31b4..8bbb0084abb1 100644
--- a/rust/kernel/uaccess.rs
+++ b/rust/kernel/uaccess.rs
@@ -481,6 +481,56 @@ pub fn write_slice(&mut self, data: &[u8]) -> Result {
Ok(())
}
+ /// Writes raw data to this user pointer from a raw kernel pointer.
+ ///
+ /// This is similar to [`Self::write_slice`] but takes a raw pointer instead of a slice,
+ /// along with a total buffer length, an offset into the that buffer, and a count of bytes
+ /// to copy.
+ ///
+ /// Returns error if the offset+count exceeds the buffer size.
+ ///
+ /// Fails with [`EFAULT`] if the write happens on a bad address, or if the write goes out of
+ /// bounds of this [`UserSliceWriter`]. This call may modify the associated userspace slice
+ /// even if it returns an error.
+ ///
+ /// # Safety
+ ///
+ /// - `data` must point to a valid memory region of at least `len` bytes that remains allocated
+ /// for the duration of this call.
+ ///
+ /// Note: Unlike [`Self::write_slice`], this method does not require exclusive access to the
+ /// source memory. The memory may be concurrently modified by other threads or hardware (e.g.,
+ /// DMA buffers). In such cases, the copied data may be inconsistent, but this does not cause
+ /// undefined behavior.
+ pub unsafe fn write_buffer(
+ &mut self,
+ data: *const u8,
+ len: usize,
+ offset: usize,
+ count: usize,
+ ) -> Result {
+ if offset.checked_add(count).ok_or(EOVERFLOW)? > len {
+ return Err(ERANGE);
+ }
+
+ // SAFETY: The caller guarantees that `data` is valid for reads of `len` bytes,
+ // so `data.add(offset_val)` is valid for reads of `count` bytes.
+ let src_ptr = unsafe { data.add(offset) };
+
+ // SAFETY: `src_ptr` is valid for reads of `to_write` bytes per the above.
+ let res = unsafe {
+ bindings::copy_to_user(self.ptr.as_mut_ptr(), src_ptr.cast::<c_void>(), count)
+ };
+ if res != 0 {
+ return Err(EFAULT);
+ }
+
+ self.ptr = self.ptr.wrapping_byte_add(count);
+ self.length -= count;
+
+ Ok(())
+ }
+
/// Writes raw data to this user pointer from a kernel buffer partially.
///
/// This is the same as [`Self::write_slice`] but considers the given `offset` into `data` and
--
2.52.0
next prev parent reply other threads:[~2026-01-16 21:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 21:49 [PATCH v5 0/8] gpu: nova-core: expose the logging buffers via debugfs Timur Tabi
2026-01-16 21:49 ` [PATCH v5 1/8] rust: pci: add device name method Timur Tabi
2026-01-17 11:09 ` Danilo Krummrich
2026-01-27 21:04 ` Timur Tabi
2026-01-27 21:07 ` Danilo Krummrich
2026-01-16 21:49 ` [PATCH v5 2/8] rust: debugfs: add Dir::empty() for conditional debugfs usage Timur Tabi
2026-01-19 12:08 ` Gary Guo
2026-01-20 17:54 ` Matthew Maurer
2026-01-20 18:19 ` Danilo Krummrich
2026-01-16 21:49 ` Timur Tabi [this message]
2026-01-17 11:18 ` [PATCH v5 3/8] rust: uaccess: add UserSliceWriter::write_buffer() for raw pointer writes Danilo Krummrich
2026-01-17 11:19 ` Danilo Krummrich
2026-01-17 13:23 ` Alice Ryhl
2026-01-17 14:23 ` Alice Ryhl
2026-01-17 14:35 ` Danilo Krummrich
2026-01-19 12:13 ` Gary Guo
2026-01-19 12:38 ` Danilo Krummrich
2026-01-16 21:49 ` [PATCH v5 4/8] gpu: nova-core: implement BinaryWriter for LogBuffer Timur Tabi
2026-01-17 11:22 ` Danilo Krummrich
2026-01-19 12:17 ` Gary Guo
2026-01-28 20:20 ` Timur Tabi
2026-01-16 21:49 ` [PATCH v5 5/8] gpu: nova-core: Replace module_pci_driver! with explicit module init Timur Tabi
2026-01-17 11:24 ` Danilo Krummrich
2026-01-28 20:52 ` Timur Tabi
2026-01-16 21:49 ` [PATCH v5 6/8] gpu: nova-core: use pin projection in method boot() Timur Tabi
2026-01-16 21:49 ` [PATCH v5 7/8] gpu: nova-core: create debugfs root in module init Timur Tabi
2026-01-17 12:18 ` Danilo Krummrich
2026-01-17 12:29 ` Danilo Krummrich
2026-01-17 20:58 ` Timur Tabi
2026-01-17 21:35 ` Danilo Krummrich
2026-01-17 21:52 ` Timur Tabi
2026-01-17 22:00 ` Danilo Krummrich
2026-01-16 21:49 ` [PATCH v5 8/8] gpu: nova-core: create GSP-RM logging buffers debugfs entries Timur Tabi
2026-01-17 12:21 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116214959.641032-4-ttabi@nvidia.com \
--to=ttabi@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=mmaurer@google.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox