public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Gary Guo <gary@garyguo.net>
To: "Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>
Cc: rust-for-linux@vger.kernel.org
Subject: [PATCH 0/3] Remove redundant imports of items re-exported from prelude
Date: Fri, 23 Jan 2026 17:19:39 +0000	[thread overview]
Message-ID: <20260123172007.136873-1-gary@garyguo.net> (raw)

We had a few occurrence of these redundant imports and up until now they're
mostly checked by human reviews.

I have now implemented a new lint in klint, which is able to spot these and
advice on using prelude imports instead. It caught a few existing cases
that slip through the review. Thus, fix them.

Link: https://github.com/Rust-for-Linux/klint/blob/trunk/doc/not_using_prelude.md

Gary Guo (3):
  gpu: nova-core: remove imports available via prelude
  block: rnull: remove imports available via prelude
  samples: rust: remove imports available via prelude

 drivers/block/rnull/configfs.rs         |  1 -
 drivers/block/rnull/rnull.rs            |  3 ---
 drivers/gpu/nova-core/firmware/fwsec.rs |  1 -
 drivers/gpu/nova-core/firmware/gsp.rs   | 12 +++++-------
 drivers/gpu/nova-core/firmware/riscv.rs |  2 --
 drivers/gpu/nova-core/gsp/sequencer.rs  |  8 +-------
 drivers/gpu/nova-core/sbuffer.rs        |  5 +----
 samples/rust/rust_driver_auxiliary.rs   |  1 -
 samples/rust/rust_misc_device.rs        |  2 --
 samples/rust/rust_print_main.rs         |  2 +-
 10 files changed, 8 insertions(+), 29 deletions(-)


base-commit: a0c666c25aeefd16f4b088c6549a6fb6b65a8a1d
-- 
2.51.2


             reply	other threads:[~2026-01-23 17:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23 17:19 Gary Guo [this message]
2026-01-23 17:19 ` [PATCH 1/3] gpu: nova-core: remove imports available via prelude Gary Guo
2026-01-25 21:17   ` Danilo Krummrich
2026-01-27 11:30     ` Danilo Krummrich
2026-01-27 11:44       ` Miguel Ojeda
2026-01-30  4:42   ` Miguel Ojeda
2026-01-23 17:19 ` [PATCH 2/3] block: rnull: " Gary Guo
2026-01-26 18:27   ` Andreas Hindborg
2026-01-26 18:37     ` Miguel Ojeda
2026-01-27 12:51       ` Andreas Hindborg
2026-01-23 17:19 ` [PATCH 3/3] samples: rust: " Gary Guo
2026-01-25 21:17   ` Danilo Krummrich
2026-01-26  9:23   ` Alice Ryhl
2026-01-26 15:02   ` Miguel Ojeda
2026-01-26 16:04     ` Greg Kroah-Hartman
2026-01-27 11:10   ` Miguel Ojeda
2026-01-30 12:45     ` Dirk Behme
2026-01-30 14:24       ` Gary Guo
2026-01-25 21:07 ` [PATCH 0/3] Remove redundant imports of items re-exported from prelude Miguel Ojeda
2026-01-27 16:45 ` (subset) " Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260123172007.136873-1-gary@garyguo.net \
    --to=gary@garyguo.net \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox