public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: engineer.jjhama@gmail.com
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 3/3] char: rttyprintk: add Rust TTY printk driver
Date: Mon, 26 Jan 2026 13:53:12 +0100	[thread overview]
Message-ID: <2026012603-flail-explore-f8e7@gregkh> (raw)
In-Reply-To: <20260126-rust-tty-printk-driver-v1-3-28604e7e100e@gmail.com>

On Mon, Jan 26, 2026 at 12:22:10PM +0000, SeungJong Ha via B4 Relay wrote:
> +        let opts = tty::Options {
> +            driver_name: c_str!("rttyprintk"),
> +            name: c_str!("rttyprintk"),
> +            major: tty::TTYAUX_MAJOR,
> +            minor_start: 4,

You are not documenting the "take over" of this minor number under this
major number anywhere, which isn't ok for using a static minor number.

And while I understand the need for an example driver, the ttyprintk
driver is a very trivial one overall, we don't need another one in the
system as one is enough :)

thanks,

greg k-h

  reply	other threads:[~2026-01-26 12:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 12:22 [PATCH RFC 0/3] rust: tty: introduce TTY subsystem abstractions and rttyprintk SeungJong Ha via B4 Relay
2026-01-26 12:22 ` [PATCH RFC 1/3] rust: bindings: add TTY subsystem headers SeungJong Ha via B4 Relay
2026-01-26 12:22 ` [PATCH RFC 2/3] rust: tty: add TTY subsystem abstractions SeungJong Ha via B4 Relay
2026-01-26 12:55   ` Greg Kroah-Hartman
2026-01-26 13:17     ` 하승종
2026-01-26 12:22 ` [PATCH RFC 3/3] char: rttyprintk: add Rust TTY printk driver SeungJong Ha via B4 Relay
2026-01-26 12:53   ` Greg Kroah-Hartman [this message]
2026-01-26 13:21     ` 하승종
2026-01-26 12:48 ` [PATCH RFC 0/3] rust: tty: introduce TTY subsystem abstractions and rttyprintk Greg Kroah-Hartman
2026-01-26 13:13   ` 하승종
2026-01-26 13:24     ` Miguel Ojeda
2026-01-26 13:50       ` 하승종

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026012603-flail-explore-f8e7@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=arnd@arndb.de \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=engineer.jjhama@gmail.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox