public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: engineer.jjhama@gmail.com
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 0/3] rust: tty: introduce TTY subsystem abstractions and rttyprintk
Date: Mon, 26 Jan 2026 13:48:14 +0100	[thread overview]
Message-ID: <2026012652-case-subsector-f671@gregkh> (raw)
In-Reply-To: <20260126-rust-tty-printk-driver-v1-0-28604e7e100e@gmail.com>

On Mon, Jan 26, 2026 at 12:22:07PM +0000, SeungJong Ha via B4 Relay wrote:
> Hello,
> 
> This RFC patch series introduces Rust abstractions for the
> TTY subsystem and implements a sample driver, rttyprintk.
> 
> Currently, TTY abstractions are missing in the
> Rust for Linux implementation. This series aims to fill that gap.
> 
> It consists of two main parts:
> - Rust TTY abstractions

What type of new tty driver are you writing that you need these
bindings?  The need for new tty drivers is quite low based on the lack
of new ones being added to the tree anymore.  Are you sure you just
don't want a serial port driver instead?

> - The rttyprintk driver
> rttyprintk serves as the first example of a Rust TTY driver.
> I chose to port ttyprintk because its simplicity makes it and 
> ideal candidate for validating the new abstractions and demonstrating
> their usage.

I would want to see a real need for this before going any further.  It's
great that you created these bindings, but without a need, I don't see
why this should even be reviewed.

thanks,

greg k-h

  parent reply	other threads:[~2026-01-26 12:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 12:22 [PATCH RFC 0/3] rust: tty: introduce TTY subsystem abstractions and rttyprintk SeungJong Ha via B4 Relay
2026-01-26 12:22 ` [PATCH RFC 1/3] rust: bindings: add TTY subsystem headers SeungJong Ha via B4 Relay
2026-01-26 12:22 ` [PATCH RFC 2/3] rust: tty: add TTY subsystem abstractions SeungJong Ha via B4 Relay
2026-01-26 12:55   ` Greg Kroah-Hartman
2026-01-26 13:17     ` 하승종
2026-01-26 12:22 ` [PATCH RFC 3/3] char: rttyprintk: add Rust TTY printk driver SeungJong Ha via B4 Relay
2026-01-26 12:53   ` Greg Kroah-Hartman
2026-01-26 13:21     ` 하승종
2026-01-26 12:48 ` Greg Kroah-Hartman [this message]
2026-01-26 13:13   ` [PATCH RFC 0/3] rust: tty: introduce TTY subsystem abstractions and rttyprintk 하승종
2026-01-26 13:24     ` Miguel Ojeda
2026-01-26 13:50       ` 하승종

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026012652-case-subsector-f671@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=arnd@arndb.de \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=engineer.jjhama@gmail.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox