From: John Hubbard <jhubbard@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"Zhi Wang" <zhiw@nvidia.com>, "David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"John Hubbard" <jhubbard@nvidia.com>
Subject: [PATCH v2 06/30] gpu: nova-core: apply the one "use" item per line policy to commands.rs
Date: Fri, 30 Jan 2026 16:55:40 -0800 [thread overview]
Message-ID: <20260131005604.454172-7-jhubbard@nvidia.com> (raw)
In-Reply-To: <20260131005604.454172-1-jhubbard@nvidia.com>
As per [1], we need one "use" item per line, in order to reduce merge
conflicts. Furthermore, we need a trailing ", //" in order to tell
rustfmt(1) to leave it alone.
This does that for commands.rs, which is the only file in nova-core that
has any remaining instances of the old style.
[1] https://docs.kernel.org/rust/coding-guidelines.html#imports
Reviewed-by: Gary Guo <gary@garyguo.net>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
drivers/gpu/nova-core/gsp/fw/commands.rs | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/nova-core/gsp/fw/commands.rs b/drivers/gpu/nova-core/gsp/fw/commands.rs
index 21be44199693..470d8edb62ff 100644
--- a/drivers/gpu/nova-core/gsp/fw/commands.rs
+++ b/drivers/gpu/nova-core/gsp/fw/commands.rs
@@ -1,8 +1,14 @@
// SPDX-License-Identifier: GPL-2.0
-use kernel::prelude::*;
-use kernel::transmute::{AsBytes, FromBytes};
-use kernel::{device, pci};
+use kernel::{
+ device,
+ pci,
+ prelude::*,
+ transmute::{
+ AsBytes,
+ FromBytes, //
+ }, //
+};
use crate::gsp::GSP_PAGE_SIZE;
--
2.52.0
next prev parent reply other threads:[~2026-01-31 0:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 0:55 [PATCH v2 00/30] gpu: nova-core: firmware: Hopper/Blackwell support John Hubbard
2026-01-31 0:55 ` [PATCH v2 01/30] gpu: nova-core: print FB sizes, along with ranges John Hubbard
2026-02-02 14:47 ` Gary Guo
2026-01-31 0:55 ` [PATCH v2 02/30] gpu: nova-core: add FbRange.len() and use it in boot.rs John Hubbard
2026-01-31 0:55 ` [PATCH v2 03/30] gpu: nova-core: Hopper/Blackwell: basic GPU identification John Hubbard
2026-01-31 0:55 ` [PATCH v2 04/30] gpu: nova-core: factor .fwsignature* selection into a new get_gsp_sigs_section() John Hubbard
2026-01-31 0:55 ` [PATCH v2 05/30] gpu: nova-core: use GPU Architecture to simplify HAL selections John Hubbard
2026-01-31 0:55 ` John Hubbard [this message]
2026-01-31 0:55 ` [PATCH v2 07/30] gpu: nova-core: set DMA mask width based on GPU architecture John Hubbard
2026-01-31 0:55 ` [PATCH v2 08/30] gpu: nova-core: Hopper/Blackwell: skip GFW boot waiting John Hubbard
2026-02-02 14:49 ` Gary Guo
2026-02-02 14:52 ` Danilo Krummrich
2026-02-02 21:37 ` John Hubbard
2026-01-31 0:55 ` [PATCH v2 09/30] gpu: nova-core: move firmware image parsing code to firmware.rs John Hubbard
2026-01-31 0:55 ` [PATCH v2 10/30] gpu: nova-core: factor out a section_name_eq() function John Hubbard
2026-01-31 0:55 ` [PATCH v2 11/30] gpu: nova-core: don't assume 64-bit firmware images John Hubbard
2026-01-31 0:55 ` [PATCH v2 12/30] gpu: nova-core: add support for 32-bit " John Hubbard
2026-01-31 0:55 ` [PATCH v2 13/30] gpu: nova-core: add auto-detection of 32-bit, 64-bit " John Hubbard
2026-01-31 0:55 ` [PATCH v2 14/30] gpu: nova-core: Hopper/Blackwell: add FMC firmware image, in support of FSP John Hubbard
2026-01-31 0:55 ` [PATCH v2 15/30] gpu: nova-core: Hopper/Blackwell: add FSP falcon engine stub John Hubbard
2026-01-31 0:55 ` [PATCH v2 16/30] gpu: nova-core: Hopper/Blackwell: add FSP falcon EMEM operations John Hubbard
2026-01-31 0:55 ` [PATCH v2 17/30] gpu: nova-core: Hopper/Blackwell: add FSP message infrastructure John Hubbard
2026-01-31 0:55 ` [PATCH v2 18/30] gpu: nova-core: Hopper/Blackwell: calculate reserved FB heap size John Hubbard
2026-01-31 0:55 ` [PATCH v2 19/30] gpu: nova-core: Hopper/Blackwell: add FSP secure boot completion waiting John Hubbard
2026-01-31 0:55 ` [PATCH v2 20/30] gpu: nova-core: Hopper/Blackwell: add FSP message structures John Hubbard
2026-01-31 0:55 ` [PATCH v2 21/30] gpu: nova-core: Hopper/Blackwell: add FMC signature extraction John Hubbard
2026-01-31 0:55 ` [PATCH v2 22/30] gpu: nova-core: Hopper/Blackwell: add FSP send/receive messaging John Hubbard
2026-01-31 0:55 ` [PATCH v2 23/30] gpu: nova-core: Hopper/Blackwell: add FSP Chain of Trust boot John Hubbard
2026-01-31 0:55 ` [PATCH v2 24/30] gpu: nova-core: Hopper/Blackwell: larger non-WPR heap John Hubbard
2026-01-31 0:55 ` [PATCH v2 25/30] gpu: nova-core: Hopper/Blackwell: larger WPR2 (GSP) heap John Hubbard
2026-01-31 0:56 ` [PATCH v2 26/30] gpu: nova-core: refactor SEC2 booter loading into run_booter() helper John Hubbard
2026-01-31 0:56 ` [PATCH v2 27/30] gpu: nova-core: Hopper/Blackwell: add GSP lockdown release polling John Hubbard
2026-01-31 0:56 ` [PATCH v2 28/30] gpu: nova-core: Hopper/Blackwell: add FSP Chain of Trust boot path John Hubbard
2026-01-31 0:56 ` [PATCH v2 29/30] gpu: nova-core: Hopper/Blackwell: new location for PCI config mirror John Hubbard
2026-01-31 0:56 ` [PATCH v2 30/30] gpu: nova-core: clarify the GPU firmware boot steps John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260131005604.454172-7-jhubbard@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox