From: Timur Tabi <ttabi@nvidia.com>
To: Gary Guo <gary@garyguo.net>, Alice Ryhl <aliceryhl@google.com>,
<mmaurer@google.com>, Danilo Krummrich <dakr@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
<nouveau@lists.freedesktop.org>, <rust-for-linux@vger.kernel.org>
Subject: [PATCH v7 0/7] gpu: nova-core: expose the logging buffers via debugfs
Date: Tue, 3 Feb 2026 16:47:50 -0600 [thread overview]
Message-ID: <20260203224757.871729-1-ttabi@nvidia.com> (raw)
GSP-RM writes its printf message to "logging buffers", which are blocks
memory allocated by the driver. The messages are encoded, so exposing
the buffers as debugfs entries allows the buffers to be extracted and
decoded by a special application.
When the driver loads, a /sys/kernel/debug/nova_core root entry is
created. To do this, the normal module_pci_driver! macro call is
replaced with an explicit initialization function, as this allows
that debugfs entry to be created once for all GPUs.
Then in each GPU's initialization, a subdirectory based on the PCI
BDF name is created, and the logging buffer entries are created under
that.
These entries are gated on a CONFIG_NOVA_CORE_DEBUGFS Kconfig option.
Note: the debugfs entry has a file size of 0, because debugfs defaults
a 0 size and the Rust abstractions do not adjust it for the same of
the object. Nouveau makes this adjustment manually in the driver.
Changes since v6:
1. Removed NOVA_CORE_DEBUGFS Kconfig
2. Expanded some SAFETY and PANIC comments
3. Added write_dma() and write_raw()
4. Renamed BinaryWriter patch
5. Moved misplaced diff in BinaryWriter patch
6. Miscellaneous minor changes.
Timur Tabi (7):
rust: device: add device name method
rust: uaccess: add write_dma() for copying from DMA buffers to
userspace
rust: dma: implement BinaryWriter for CoherentAllocation<u8>
gpu: nova-core: Replace module_pci_driver! with explicit module init
gpu: nova-core: use pin projection in method boot()
gpu: nova-core: create debugfs root in module init
gpu: nova-core: create GSP-RM logging buffers debugfs entries
drivers/gpu/nova-core/gsp.rs | 49 ++++++++++++++++----
drivers/gpu/nova-core/gsp/boot.rs | 14 +++---
drivers/gpu/nova-core/nova_core.rs | 50 +++++++++++++++++++-
rust/helpers/device.c | 5 ++
rust/kernel/device.rs | 10 ++++
rust/kernel/dma.rs | 36 ++++++++++++++-
rust/kernel/uaccess.rs | 74 +++++++++++++++++++++++++-----
7 files changed, 210 insertions(+), 28 deletions(-)
base-commit: cea7b66a80412e2a5b74627b89ae25f1d0110a4b
--
2.52.0
next reply other threads:[~2026-02-03 22:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 22:47 Timur Tabi [this message]
2026-02-03 22:47 ` [PATCH v7 1/7] rust: device: add device name method Timur Tabi
2026-02-03 22:47 ` [PATCH v7 2/7] rust: uaccess: add write_dma() for copying from DMA buffers to userspace Timur Tabi
2026-02-04 2:06 ` kernel test robot
2026-02-04 20:01 ` Timur Tabi
2026-03-09 19:59 ` Danilo Krummrich
2026-03-10 19:52 ` Timur Tabi
2026-03-10 19:56 ` Danilo Krummrich
2026-03-10 20:11 ` Timur Tabi
2026-03-10 20:01 ` Alice Ryhl
2026-02-03 22:47 ` [PATCH v7 3/7] rust: dma: implement BinaryWriter for CoherentAllocation<u8> Timur Tabi
2026-02-03 22:47 ` [PATCH v7 4/7] gpu: nova-core: Replace module_pci_driver! with explicit module init Timur Tabi
2026-02-03 22:47 ` [PATCH v7 5/7] gpu: nova-core: use pin projection in method boot() Timur Tabi
2026-02-03 22:47 ` [PATCH v7 6/7] gpu: nova-core: create debugfs root in module init Timur Tabi
2026-02-03 22:47 ` [PATCH v7 7/7] gpu: nova-core: create GSP-RM logging buffers debugfs entries Timur Tabi
2026-02-10 3:28 ` [PATCH v7 0/7] gpu: nova-core: expose the logging buffers via debugfs John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203224757.871729-1-ttabi@nvidia.com \
--to=ttabi@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=mmaurer@google.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox