From: Alexandre Courbot <acourbot@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Alice Ryhl <aliceryhl@google.com>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>
Cc: John Hubbard <jhubbard@nvidia.com>,
Alistair Popple <apopple@nvidia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
Timur Tabi <ttabi@nvidia.com>, Edwin Peer <epeer@nvidia.com>,
Eliot Courtney <ecourtney@nvidia.com>,
nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v9 2/9] gpu: nova-core: require DmaObject on FalconDmaLoadable, not FalconFirmware
Date: Thu, 12 Feb 2026 17:26:19 +0900 [thread overview]
Message-ID: <20260212-turing_prep-v9-2-238520ad8799@nvidia.com> (raw)
In-Reply-To: <20260212-turing_prep-v9-0-238520ad8799@nvidia.com>
Not all firmware is necessarily loaded through DMA: the PIO loading
method does not require shared memory between the CPU and GPU. Thus,
move the requirement to dereference to a DMA object from
`FalconFirmware` to the mode accurate `FalconDmaLoadable`.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
drivers/gpu/nova-core/falcon.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/nova-core/falcon.rs b/drivers/gpu/nova-core/falcon.rs
index 85918a03b37c..d2f27847f533 100644
--- a/drivers/gpu/nova-core/falcon.rs
+++ b/drivers/gpu/nova-core/falcon.rs
@@ -351,7 +351,7 @@ pub(crate) struct FalconDmaLoadTarget {
}
/// Trait for providing DMA load parameters of falcon firmwares.
-pub(crate) trait FalconDmaLoadable {
+pub(crate) trait FalconDmaLoadable: Deref<Target = DmaObject> {
/// Returns the load parameters for Secure `IMEM`.
fn imem_sec_load_params(&self) -> FalconDmaLoadTarget;
@@ -373,7 +373,7 @@ pub(crate) trait FalconDmaLoadable {
///
/// A falcon firmware can be loaded on a given engine, and is presented in the form of a DMA
/// object.
-pub(crate) trait FalconFirmware: FalconDmaLoadable + Deref<Target = DmaObject> {
+pub(crate) trait FalconFirmware: FalconDmaLoadable {
/// Engine on which this firmware is to be loaded.
type Target: FalconEngine;
}
--
2.53.0
next prev parent reply other threads:[~2026-02-12 8:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 8:26 [PATCH v9 0/9] gpu: nova-core: add Turing support Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 1/9] gpu: nova-core: falcon: rename load parameters to reflect DMA dependency Alexandre Courbot
2026-02-12 8:26 ` Alexandre Courbot [this message]
2026-02-12 8:26 ` [PATCH v9 3/9] gpu: nova-core: falcon: remove generic argument from dma_wr Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 4/9] gpu: nova-core: falcon: remove FalconFirmware's dependency on FalconDmaLoadable Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 5/9] gpu: nova-core: move brom_params and boot_addr to FalconFirmware Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 6/9] gpu: nova-core: add PIO support for loading firmware images Alexandre Courbot
2026-02-13 14:47 ` Danilo Krummrich
2026-02-22 10:57 ` Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 7/9] gpu: nova-core: make Chipset::arch() const Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 8/9] gpu: nova-core: add gen_bootloader firmware to ModInfoBuilder Alexandre Courbot
2026-02-12 8:26 ` [PATCH v9 9/9] gpu: nova-core: use the Generic Bootloader to boot FWSEC on Turing Alexandre Courbot
2026-02-24 2:31 ` Eliot Courtney
2026-02-27 4:21 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260212-turing_prep-v9-2-238520ad8799@nvidia.com \
--to=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ecourtney@nvidia.com \
--cc=epeer@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox