From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010065.outbound.protection.outlook.com [52.101.46.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 551102BE644; Wed, 25 Feb 2026 19:18:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.65 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772047125; cv=fail; b=YV58MoEwEAZJJ/RlV076f2RFzI+pMZfTX2ohpX6JkbsyI98L5uXeHe+TnHglapLcTPNazXtut0MzPq96xuVM067WOQ99mtFQRDUOTd4OVlUaBZw1iukc5t71xT62brsZexnRiQF4IYEgZm+gi5DPfeszNXVpZ9YC+xc3fkVqORc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772047125; c=relaxed/simple; bh=ZcAt6oCHXibqBk0oftlBrp9Ra2zwTBaX8uEB+orzQqc=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Y8KXMWwqrEsDSgJPKwQBb/RACgwGc563W24T4sRypwrrgZh9PRRPOkImaS7afeMTgrNR5oKAGdJA/v2puefhrpttNdx2ypDWtlH45eyEKUoW+78B3Wk49Pl01icWUzD8Ny7YQduWeLj7sdxasNCMKVgvh5SQ6ZrX37VeGUrrPjw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Uppp+0Hb; arc=fail smtp.client-ip=52.101.46.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Uppp+0Hb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s9hGAKhl3pkW2ubl3jjYrfU9JCiAFmQBSyMvzGZ/OVpkXLNSG+nnDTJMEC5PHGBNz66UBxxxSyyEddZwwZWd2AiAzQRcMz7rFrOWo6fumyfG5Sr7ru8eMmyzn6LaYjIlj7eEKKNy9ph8g/DykVLdPglLNVJ5KAGBReegrcJECYfsUPmYy/r93v7apJYQOq+LzW6liuWErAmnsxxkiSTlXbuKrCHKBNjN92V5yBl83sRVuZiWhRvH10xfWZ8osfHqP0AXiDxWpmP1HXb30qnqgtq7z4s4patuzFA3SDn87zVWlk1b0IxglSZlRANVb9nFC7mIsmGrKm3ZsG0ZmyYzxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NyzL/fsHbv2ZMpapjypAwpDqKVt9wI2RRIACGYLc7rs=; b=KojfHfmNVWQqKncuRV9O74EPWfr/hWNlSXUq+e37WjE70f6GkeKieeroCCN2xVLAEy1CPQIPN8aB8bQXealckpmopW5N9h0ZuL8U+pGL1cE5D3qDmNLpXn6iWEdAijxNKj6M6QBmR8nX3oFoxWLgjP2lZPZh52Z02/oPnR4GZDzMENWHEbcWCYuS6aPSeOmAgxIJxS3QzhwQdiUG0tNPTvZh38KETqc0gF5+C+VoeaVJBqvSsgKvguYMdVpflcEuCPDXULbdnXefTsyUSGsybj9iyiubXIezPB8K5KIIvEDt5lMnPRI7h5V1fNkIC+LRjhL6fkQI1S1oce9pncLJCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NyzL/fsHbv2ZMpapjypAwpDqKVt9wI2RRIACGYLc7rs=; b=Uppp+0HbVL/EVasMADGjJ9y41hK2UXxP7/zCQD1u92NAozDuqjMDVcI/PP2P99lx6FdRoJfhN262tkZNDQYDzQx1G2r48shNzl7rNKWGOVj7Ty34DpJRLdjBnuJTxAZ+5gNtepp5g4Qxy5iStrZYQtN5lGLV+sKoXO+IrEYnnEQdzSiXrxGcMctq5Hsddg982cZnyl/fHNpoe9pKZFkaIdJ0GSXzhGC/cO9EAgQAFGasizguWoiNvrV5GvFu5Kjs7hg/dHwO6HI5lZbR4E+adM0bFK3X5ySMye6L8vq/Uy9P+uRgwVwKYMo+uR85RQrvka210guUwtRDAk8fbmJNcw== Received: from SJ0PR13CA0028.namprd13.prod.outlook.com (2603:10b6:a03:2c0::33) by IA1PR12MB9524.namprd12.prod.outlook.com (2603:10b6:208:596::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Wed, 25 Feb 2026 19:18:39 +0000 Received: from SJ1PEPF000023D2.namprd02.prod.outlook.com (2603:10b6:a03:2c0:cafe::da) by SJ0PR13CA0028.outlook.office365.com (2603:10b6:a03:2c0::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.22 via Frontend Transport; Wed, 25 Feb 2026 19:18:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ1PEPF000023D2.mail.protection.outlook.com (10.167.244.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Wed, 25 Feb 2026 19:18:39 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 25 Feb 2026 11:18:24 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Wed, 25 Feb 2026 11:18:23 -0800 Received: from inno-dell (10.127.8.10) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Wed, 25 Feb 2026 11:18:16 -0800 Date: Wed, 25 Feb 2026 21:18:10 +0200 From: Zhi Wang To: Eliot Courtney CC: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , "Boqun Feng" , Gary Guo , "=?UTF-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , , , , Subject: Re: [PATCH v2 0/9] gpu: nova-core: gsp: add continuation record support Message-ID: <20260225211810.3142ccd7@inno-dell> In-Reply-To: <20260219-cmdq-continuation-v2-0-2e8b7615536f@nvidia.com> References: <20260219-cmdq-continuation-v2-0-2e8b7615536f@nvidia.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.50; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000023D2:EE_|IA1PR12MB9524:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ff17ca3-e42b-4ef9-706d-08de74a2ae84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700013; X-Microsoft-Antispam-Message-Info: 24UuwQwqhXw4ROK9AsVM6ySYBHm5U1oTcB1nBHWjWRTAwbPq91u3jgwEaqe4+gyT5FfR3JgfZFgCALlYg9pzz9y+ctJqE+ZuXG7l1/Y24qjEJxFFDj2CjvxQe6MAXl+C4gQpE4lDlH0agHodMkoMaI32LUj4HiG5R1muDYvfjI9mWDyomfjrp0c1mTZMU4FKmcBmdc5QZhPN6bcRCWYfBTzXeWDDE0/ILSFrg69dItPRPEZfcmuXqF+5m1BUd0260mGZvNlCyo3BLtXDOdndspLGKscudSttvkfki/t5q5LCFWet7/W7icX7F7egJDqTYJNEfNdHSgHNjLgLD7+NWPyZox15xV1nTYNMfHCkbmVz9+EhDPhBflDNm/Ana4k3Au835YzQq0FMTyurdQy+Go8ZUrZFLYPTIJY68PWUDlhF1p1ovkRbfPjvlxiPBl8hYSXeOB7c3d1oS7xfF/wKke618dP7LksureoZky8E1ZOzKTdLzcaAXt9GY3PnvLN9r/y5AWNf+pvoxv/NbXgtrJhC32VthUnWaZLGp7g4QPbIcucugav4mLOKL9xdQDL/3s+4yfZsU9JUWwJLt3Lj4zzWWasSOptgOZngou7AWzLVSEmKG3yq8XUM1PJJFjtwDg6CMu3zou+RXUK0RZbYYEJoIZ1NNlmeCJMuXgNlyCzKOLQXT5n/0Y1E0388HHIy2zU9uoU22I5tj2Q57AqevJAYI8HiliKu/FC5wQkoyW73XTmjYgYCDgQkFAVrQ52/JOymGkYumtsSKQ/Y196rmKfKcvLQNoKA4AdhW+dMfHuWENDAfvSXNgU31heXBF1E20sNKcO75C7pNa2EA2xyMA== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700013);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5pLvKu5nj4LYK9eDzx1Y94qhduApQO0wz/t2H9soIElXjrxFupzOyX4pcgumqSRn7OY6VK+3EZsTFsj4x6pS/zASRtLo6GUYF6JhEUBcyIGlb4h5updKj6GG3CWTQBZUiJGvqb4ksvcGmskSS4oMfY3BfUJthEsUWCZNDmR0omRMZW6OuWnUlyp3Ki1Y1ZJ1l/7E3bvRXFT/XO4qol/dp8jDLCrbCk22ijwNE6Z53NyjhfRNY20Zgjwcw7gLkT0l6mCPB2Dwze0EGOh/mx3CDhF0AIZ1N7K4ncTyZvBSTZnQb4PWPzo59TtVOygsfslDwFJe15k8pE82l6/bC9j74J0VqIvXL9VqeWByGoD2O7RBsJmMEG7K5jJnj4MmpQXdvWFFNavG1441P2a1MbNFgPscN2pSmI/mIK2S05pS7OBe573+a8qp1LTWNJH//T56 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2026 19:18:39.4360 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ff17ca3-e42b-4ef9-706d-08de74a2ae84 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000023D2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB9524 On Thu, 19 Feb 2026 16:30:49 +0900 Eliot Courtney wrote: Tested-by: Zhi Wang > GSP commands over 16 pages need to be sent using "continuation > records" which essentially means splitting the payload over multiple > commands. > > This series adds a command type `ContinuationRecord` which just writes > its header and whatever payload it is given. It also adds types > `SplitState` and `SplitCommand` which support splitting a large RPC > into smaller ones while transparently letting regular sized RPCs be > sent without extra copies. > > The send pathway uses `SplitState` to send all commands, but if > the command fits into 16 pages, it still writes directly into the > command queue. If it is larger than 16 pages and needs continuation > records, it writes into a staging buffer, so there is one copy. > > Signed-off-by: Eliot Courtney > --- > Changes in v2: > - Added doccoments > - Renamed driver_bytes_available_to_write to driver_write_area_size > - allocate_command_with_timeout merged allocate_command with timeout > parameter > - Replaced hardcoded GSP_PAGE_SIZE * 16 with bindings > - Changed oversized command error from EIO to EMSGSIZE > - Added EMSGSIZE to kernel/error.rs > - Split WrappingCommand functionality into SplitState + SplitCommand > enum > - Made max_size a const (MAX_CMD_SIZE) > - Removed send_continuation_record + added comment for type inference > - send_single_command now consumes the command > - Extracted command_size + used in SplitState > - Link to v1: > https://lore.kernel.org/r/20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com > > --- > Eliot Courtney (9): > gpu: nova-core: gsp: sort MsgFunction variants alphabetically > gpu: nova-core: gsp: add mechanism to wait for space on command > queue rust: add EMSGSIZE error code > gpu: nova-core: gsp: add checking oversized commands > gpu: nova-core: gsp: clarify invariant on command queue > gpu: nova-core: gsp: unconditionally call variable payload > handling gpu: nova-core: gsp: add command_size helper > gpu: nova-core: gsp: support large RPCs via continuation record > gpu: nova-core: gsp: add tests for SplitState > > drivers/gpu/nova-core/gsp/cmdq.rs | 118 +++++++--- > drivers/gpu/nova-core/gsp/commands.rs | 256 > +++++++++++++++++++++- drivers/gpu/nova-core/gsp/fw.rs > | 106 +++++---- drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs > | 1 + rust/kernel/error.rs | 1 + > 5 files changed, 408 insertions(+), 74 deletions(-) > --- > base-commit: 956b9cbd7f156c8672dac94a00de3c6a0939c692 > change-id: 20260203-cmdq-continuation-b99f3d5966c3 > > Best regards,