Re: [PATCH 2/2] staging: Add initial synology microp driver

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Mar 06, 2026 at 07:38:30PM +0000, Markus Probst wrote:
> Add a initial synology microp driver, written in Rust, to the staging tree.
> The driver targets a microcontroller found in Synology NAS devices. It
> currently only supports controlling of the power led, status led, alert
> led and usb led. Other components such as fan control or handling
> on-device buttons will be added once the required rust abstractions are
> there.
> ---
>  MAINTAINERS                                        |   6 +
>  drivers/staging/Kconfig                            |   2 +
>  drivers/staging/Makefile                           |   1 +
>  drivers/staging/synology_microp/Kconfig            |   4 +
>  drivers/staging/synology_microp/Makefile           |   2 +
>  drivers/staging/synology_microp/TODO               |   8 +
>  drivers/staging/synology_microp/command.rs         |  48 +++++
>  drivers/staging/synology_microp/led.rs             | 229 +++++++++++++++++++++
>  drivers/staging/synology_microp/synology_microp.rs |  73 +++++++
>  rust/uapi/uapi_helper.h                            |   2 +
>  10 files changed, 375 insertions(+)

No signed-off-by?

And why staging?  That's for stuff that needs obvious cleanups done to
it, you don't list that here.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index e9e83ab552c7..a1f8dec31db2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -25143,6 +25143,12 @@ L:	linux-fbdev@vger.kernel.org
>  S:	Maintained
>  F:	drivers/staging/sm750fb/
>  
> +STAGING - SYNOLOGY MICROP DRIVER
> +M:  Markus Probst <markus.probst@posteo.de>
> +S:  Maintained
> +F: Documentation/devicetree/bindings/mfd/synology,microp.yaml
> +F: drivers/staging/synology_microp/

No tabs?

thanks,

greg k-h