From: Alvin Sun <alvin.sun@linux.dev>
To: "Danilo Krummrich" <dakr@kernel.org>,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>
Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
Alvin Sun <alvin.sun@linux.dev>
Subject: [PATCH 2/2] drm/gpuvm: add GpuVaIter and va_mappings() for debugfs
Date: Tue, 17 Mar 2026 20:03:41 +0800 [thread overview]
Message-ID: <20260317-gpuvm-helpers-v1-2-00198fc6eeea@linux.dev> (raw)
In-Reply-To: <20260317-gpuvm-helpers-v1-0-00198fc6eeea@linux.dev>
Add an iterator over VA mappings so drivers can walk and dump GPU VA
state in debugfs.
Signed-off-by: Alvin Sun <alvin.sun@linux.dev>
---
rust/kernel/drm/gpuvm/mod.rs | 6 +++++
rust/kernel/drm/gpuvm/va.rs | 53 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 59 insertions(+)
diff --git a/rust/kernel/drm/gpuvm/mod.rs b/rust/kernel/drm/gpuvm/mod.rs
index 3186df9f740cf..41b99d468f9d9 100644
--- a/rust/kernel/drm/gpuvm/mod.rs
+++ b/rust/kernel/drm/gpuvm/mod.rs
@@ -301,6 +301,12 @@ pub fn data(&mut self) -> &mut T {
// SAFETY: By the type invariants we may access `core`.
unsafe { &mut *self.0.data.get() }
}
+
+ /// Returns an iterator over the VA mappings in this GpuVm.
+ #[inline]
+ pub fn va_mappings(&self) -> GpuVaIter<'_, T> {
+ GpuVaIter::new(&self.0)
+ }
}
impl<T: DriverGpuVm> Deref for GpuVmCore<T> {
diff --git a/rust/kernel/drm/gpuvm/va.rs b/rust/kernel/drm/gpuvm/va.rs
index 8b8fd500b3c5f..3210047f880e3 100644
--- a/rust/kernel/drm/gpuvm/va.rs
+++ b/rust/kernel/drm/gpuvm/va.rs
@@ -1,6 +1,14 @@
// SPDX-License-Identifier: GPL-2.0 OR MIT
use super::*;
+use crate::interop::list::{
+ CList,
+ CListIter, //
+};
+use core::{
+ marker::PhantomData,
+ mem::offset_of, //
+};
/// Represents that a range of a GEM object is mapped in this [`GpuVm`] instance.
///
@@ -118,6 +126,51 @@ pub fn length(&self) -> u64 {
}
}
+const DRM_GPUVA_LIST_ENTRY_OFFSET: usize = offset_of!(bindings::drm_gpuva, rb.entry);
+type RawGpuVaIter<'a> = CListIter<'a, RawGpuVa, DRM_GPUVA_LIST_ENTRY_OFFSET>;
+
+/// An iterator over the VA mappings in a [`GpuVm`].
+pub struct GpuVaIter<'a, T: DriverGpuVm> {
+ raw_gpuva_iter: RawGpuVaIter<'a>,
+ kern_gpuva_ptr: *mut bindings::drm_gpuva,
+ _marker: PhantomData<&'a T>,
+}
+
+impl<'a, T: DriverGpuVm> GpuVaIter<'a, T> {
+ #[inline]
+ pub(crate) fn new(gpuvm: &'a GpuVm<T>) -> Self {
+ // SAFETY: `gpuvm` is valid.
+ let head = unsafe { &raw mut (*gpuvm.as_raw()).rb.list };
+ // SAFETY: `head` is a valid pointer to a drm_gpuva list head.
+ let clist = unsafe { CList::<RawGpuVa, DRM_GPUVA_LIST_ENTRY_OFFSET>::from_raw(head) };
+ let kern_gpuva_ptr = gpuvm.kernel_alloc_va().as_raw();
+
+ Self {
+ raw_gpuva_iter: clist.iter(),
+ kern_gpuva_ptr,
+ _marker: PhantomData,
+ }
+ }
+}
+
+impl<'a, T: DriverGpuVm> Iterator for GpuVaIter<'a, T> {
+ type Item = &'a GpuVa<T>;
+
+ #[inline]
+ fn next(&mut self) -> Option<Self::Item> {
+ let mut curr = self.raw_gpuva_iter.next()?;
+
+ if curr.as_raw() == self.kern_gpuva_ptr {
+ // Skip kernel reserved node.
+ curr = self.raw_gpuva_iter.next()?;
+ }
+
+ // SAFETY: We have skipped the kernel reserved node, all remaining
+ // entries are valid GpuVa<T> instances.
+ Some(unsafe { GpuVa::from_raw(curr.as_raw()) })
+ }
+}
+
/// A pre-allocated [`GpuVa`] object.
///
/// # Invariants
--
2.43.0
prev parent reply other threads:[~2026-03-17 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 12:03 [PATCH 0/2] drm/gpuvm: add debugfs utilities for GPU VA state dumping Alvin Sun
2026-03-17 12:03 ` [PATCH 1/2] drm/gpuvm: add name(), RawGpuVa and kernel_alloc_va() for debugfs Alvin Sun
2026-03-17 12:03 ` Alvin Sun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260317-gpuvm-helpers-v1-2-00198fc6eeea@linux.dev \
--to=alvin.sun@linux.dev \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=lossin@kernel.org \
--cc=matthew.brost@intel.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox