public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>,
	Alexandre Courbot <acourbot@nvidia.com>
Cc: "Joel Fernandes" <joelagnelf@nvidia.com>,
	"Timur Tabi" <ttabi@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Eliot Courtney" <ecourtney@nvidia.com>,
	"Shashank Sharma" <shashanks@nvidia.com>,
	"Zhi Wang" <zhiw@nvidia.com>, "David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	rust-for-linux@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	"John Hubbard" <jhubbard@nvidia.com>
Subject: [PATCH v8 06/31] gpu: nova-core: Hopper/Blackwell: skip GFW boot waiting
Date: Tue, 24 Mar 2026 20:52:17 -0700	[thread overview]
Message-ID: <20260325035242.368661-7-jhubbard@nvidia.com> (raw)
In-Reply-To: <20260325035242.368661-1-jhubbard@nvidia.com>

Hopper and Blackwell GPUs use FSP-based secure boot and do not
require waiting for GFW_BOOT completion. Move the GFW_BOOT wait
into a GPU HAL so the decision and the wait both live in the HAL.

Pre-Hopper families (Tu102 HAL) wait for GFW_BOOT completion.
Hopper and later (Gh100 HAL) skip it and boot via FSP instead.

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 drivers/gpu/nova-core/gpu.rs     |  6 +++--
 drivers/gpu/nova-core/gpu/hal.rs | 42 ++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 2 deletions(-)
 create mode 100644 drivers/gpu/nova-core/gpu/hal.rs

diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs
index e7c3860cfb28..5cef5b29cd3f 100644
--- a/drivers/gpu/nova-core/gpu.rs
+++ b/drivers/gpu/nova-core/gpu.rs
@@ -18,11 +18,12 @@
         Falcon, //
     },
     fb::SysmemFlush,
-    gfw,
     gsp::Gsp,
     regs,
 };
 
+mod hal;
+
 macro_rules! define_chipset {
     ({ $($variant:ident = $value:expr),* $(,)* }) =>
     {
@@ -309,10 +310,11 @@ pub(crate) fn new<'a>(
         spec: Spec,
     ) -> impl PinInit<Self, Error> + 'a {
         let chipset = spec.chipset();
+        let hal = hal::gpu_hal(chipset);
 
         try_pin_init!(Self {
             _: {
-                gfw::wait_gfw_boot_completion(bar)
+                hal.wait_gfw_boot_completion(bar)
                     .inspect_err(|_| dev_err!(pdev, "GFW boot did not complete\n"))?;
             },
 
diff --git a/drivers/gpu/nova-core/gpu/hal.rs b/drivers/gpu/nova-core/gpu/hal.rs
new file mode 100644
index 000000000000..2f9e18e67a35
--- /dev/null
+++ b/drivers/gpu/nova-core/gpu/hal.rs
@@ -0,0 +1,42 @@
+// SPDX-License-Identifier: GPL-2.0
+
+use kernel::prelude::*;
+
+use crate::{
+    driver::Bar0,
+    gfw,
+    gpu::{
+        Architecture,
+        Chipset, //
+    },
+};
+
+pub(crate) trait GpuHal {
+    /// Waits for GFW_BOOT completion if required by this hardware family.
+    fn wait_gfw_boot_completion(&self, bar: &Bar0) -> Result;
+}
+
+struct Tu102;
+struct Gh100;
+
+impl GpuHal for Tu102 {
+    fn wait_gfw_boot_completion(&self, bar: &Bar0) -> Result {
+        gfw::wait_gfw_boot_completion(bar)
+    }
+}
+
+impl GpuHal for Gh100 {
+    fn wait_gfw_boot_completion(&self, _bar: &Bar0) -> Result {
+        Ok(())
+    }
+}
+
+const TU102: Tu102 = Tu102;
+const GH100: Gh100 = Gh100;
+
+pub(super) fn gpu_hal(chipset: Chipset) -> &'static dyn GpuHal {
+    match chipset.arch() {
+        Architecture::Turing | Architecture::Ampere | Architecture::Ada => &TU102,
+        Architecture::Hopper | Architecture::Blackwell => &GH100,
+    }
+}
-- 
2.53.0


  parent reply	other threads:[~2026-03-25  3:53 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25  3:52 [PATCH v8 00/31] gpu: nova-core: firmware: Hopper/Blackwell support John Hubbard
2026-03-25  3:52 ` [PATCH v8 01/31] gpu: nova-core: Hopper/Blackwell: basic GPU identification John Hubbard
2026-03-25 15:36   ` Gary Guo
2026-03-25 21:34     ` John Hubbard
2026-03-25  3:52 ` [PATCH v8 02/31] gpu: nova-core: factor .fwsignature* selection into a new find_gsp_sigs_section() John Hubbard
2026-03-25 10:45   ` Alexandre Courbot
2026-03-25 21:56     ` John Hubbard
2026-03-25  3:52 ` [PATCH v8 03/31] gpu: nova-core: use GPU Architecture to simplify HAL selections John Hubbard
2026-03-25  3:52 ` [PATCH v8 04/31] gpu: nova-core: add Copy/Clone to Spec and Revision, add chipset() accessor John Hubbard
2026-03-25 10:47   ` Alexandre Courbot
2026-03-26  1:21     ` John Hubbard
2026-03-25 15:42   ` Gary Guo
2026-03-26  1:21     ` John Hubbard
2026-03-25  3:52 ` [PATCH v8 05/31] gpu: nova-core: set DMA mask width based on GPU architecture John Hubbard
2026-03-25 10:53   ` Alexandre Courbot
2026-03-26  1:22     ` John Hubbard
2026-03-25 11:31   ` Danilo Krummrich
2026-03-25 11:45     ` Alexandre Courbot
2026-03-25 13:38       ` Danilo Krummrich
2026-03-25 13:56         ` Alexandre Courbot
2026-03-26  1:22           ` John Hubbard
2026-03-25  3:52 ` John Hubbard [this message]
2026-03-25 10:53   ` [PATCH v8 06/31] gpu: nova-core: Hopper/Blackwell: skip GFW boot waiting Alexandre Courbot
2026-03-26  1:22     ` John Hubbard
2026-03-25 15:45   ` Gary Guo
2026-03-26  1:23     ` John Hubbard
2026-03-25  3:52 ` [PATCH v8 07/31] gpu: nova-core: move firmware image parsing code to firmware.rs John Hubbard
2026-03-25  3:52 ` [PATCH v8 08/31] gpu: nova-core: factor out an elf_str() function John Hubbard
2026-03-25  3:52 ` [PATCH v8 09/31] gpu: nova-core: don't assume 64-bit firmware images John Hubbard
2026-03-25  3:52 ` [PATCH v8 10/31] gpu: nova-core: add support for 32-bit " John Hubbard
2026-03-25  3:52 ` [PATCH v8 11/31] gpu: nova-core: add auto-detection of 32-bit, 64-bit " John Hubbard
2026-03-25  3:52 ` [PATCH v8 12/31] gpu: nova-core: Hopper/Blackwell: add FMC firmware image, in support of FSP John Hubbard
2026-03-25 15:52   ` Gary Guo
2026-03-26  1:23     ` John Hubbard
2026-03-25  3:52 ` [PATCH v8 13/31] gpu: nova-core: Hopper/Blackwell: add FSP falcon engine stub John Hubbard
2026-03-25  3:52 ` [PATCH v8 14/31] gpu: nova-core: Hopper/Blackwell: add FSP falcon EMEM operations John Hubbard
2026-03-25  3:52 ` [PATCH v8 15/31] gpu: nova-core: Hopper/Blackwell: add FSP message infrastructure John Hubbard
2026-03-25  3:52 ` [PATCH v8 16/31] rust: ptr: add const_align_up() John Hubbard
2026-03-25  8:22   ` Alice Ryhl
2026-03-25 15:52   ` Gary Guo
2026-03-25  3:52 ` [PATCH v8 17/31] gpu: nova-core: Hopper/Blackwell: calculate reserved FB heap size John Hubbard
2026-03-25  3:52 ` [PATCH v8 18/31] gpu: nova-core: add MCTP/NVDM protocol types for firmware communication John Hubbard
2026-03-25  3:52 ` [PATCH v8 19/31] gpu: nova-core: Hopper/Blackwell: add FSP secure boot completion waiting John Hubbard
2026-03-25  3:52 ` [PATCH v8 20/31] gpu: nova-core: Hopper/Blackwell: add FMC signature extraction John Hubbard
2026-03-25  3:52 ` [PATCH v8 21/31] gpu: nova-core: Hopper/Blackwell: add FSP send/receive messaging John Hubbard
2026-03-25  3:52 ` [PATCH v8 22/31] gpu: nova-core: Hopper/Blackwell: add FspCotVersion type John Hubbard
2026-03-25  3:52 ` [PATCH v8 23/31] gpu: nova-core: Hopper/Blackwell: larger non-WPR heap John Hubbard
2026-03-25  3:52 ` [PATCH v8 24/31] gpu: nova-core: Hopper/Blackwell: add FSP Chain of Trust boot John Hubbard
2026-03-25  3:52 ` [PATCH v8 25/31] gpu: nova-core: Blackwell: use correct sysmem flush registers John Hubbard
2026-03-25  3:52 ` [PATCH v8 26/31] gpu: nova-core: make WPR heap sizing fallible John Hubbard
2026-03-25  3:52 ` [PATCH v8 27/31] gpu: nova-core: Hopper/Blackwell: larger WPR2 (GSP) heap John Hubbard
2026-03-25  3:52 ` [PATCH v8 28/31] gpu: nova-core: refactor SEC2 booter loading into BooterFirmware::run() John Hubbard
2026-03-25  3:52 ` [PATCH v8 29/31] gpu: nova-core: Hopper/Blackwell: add GSP lockdown release polling John Hubbard
2026-03-25  3:52 ` [PATCH v8 30/31] gpu: nova-core: Hopper/Blackwell: new location for PCI config mirror John Hubbard
2026-03-25  3:52 ` [PATCH v8 31/31] gpu: nova-core: Hopper/Blackwell: integrate FSP boot path into boot() John Hubbard
2026-03-25 15:08 ` [PATCH v8 00/31] gpu: nova-core: firmware: Hopper/Blackwell support Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325035242.368661-7-jhubbard@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=ecourtney@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=shashanks@nvidia.com \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox