From: Bjorn Helgaas <helgaas@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Gary Guo <gary@garyguo.net>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
jes@trained-monkey.org, chenhuacai@kernel.org, kernel@xen0n.name,
tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com,
deller@gmx.de, maddy@linux.ibm.com, mpe@ellerman.id.au,
npiggin@gmail.com, chleroy@kernel.org, hca@linux.ibm.com,
gor@linux.ibm.com, agordeev@linux.ibm.com,
borntraeger@linux.ibm.com, svens@linux.ibm.com,
bhelgaas@google.com, dakr@kernel.org, kwilczynski@kernel.org,
ojeda@kernel.org, boqun@kernel.org, bjorn3_gh@protonmail.com,
lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com,
tmgross@umich.edu, ebiggers@google.com, ardb@kernel.org,
tiwai@suse.de, tytso@mit.edu, enelsonmoore@gmail.com,
martin.petersen@oracle.com, jirislaby@kernel.org,
gregkh@linuxfoundation.org, geert@linux-m68k.org,
herbert@gondor.apana.org.au, vineethr@linux.ibm.com,
lirongqing@baidu.com, kshk@linux.ibm.com,
vadim.fedorenko@linux.dev, dong100@mucse.com,
wangruikang@iscas.ac.cn, hkallweit1@gmail.com, kees@kernel.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, linux-pci@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH net-next] eth: remove the driver for acenic / tigon1&2
Date: Fri, 3 Apr 2026 14:56:57 -0500 [thread overview]
Message-ID: <20260403195657.GA351015@bhelgaas> (raw)
In-Reply-To: <20260403123329.42bed564@kernel.org>
On Fri, Apr 03, 2026 at 12:33:29PM -0700, Jakub Kicinski wrote:
> On Fri, 3 Apr 2026 10:40:10 -0500 Bjorn Helgaas wrote:
> > > > -#define PCI_VENDOR_ID_ALTEON 0x12ae
> > > > -
> > > > #define PCI_SUBVENDOR_ID_CONNECT_TECH 0x12c4
> > > > #define PCI_SUBDEVICE_ID_CONNECT_TECH_BH8_232 0x0001
> > > > #define PCI_SUBDEVICE_ID_CONNECT_TECH_BH4_232 0x0002
> >
> > > Does the PCI ID needs to be removed? There was a similar change that
> > > I recalled and the discussion eventually leads to ID not being
> > > removed.
> > > https://lore.kernel.org/all/20260123033233.16906-1-enelsonmoore@gmail.com/
> >
> > I don't think there is value in removing the PCI_VENDOR_ID_ALTEON
> > definition.
>
> Do you want me to respin the patch? "there is no value" is probably fair
> but also there's no value in keeping it so LMK if you want a respin..
I think there is a little value in keeping it. Removing
PCI_VENDOR_ID_ALTEON:
- makes future backports slightly harder, e.g., we remove
PCI_VENDOR_ID_ALTEON, then add a new definition like Vendor ID
0x12af, then backport the new definition, and the backport doesn't
apply cleanly because the context doesn't match.
- means we wouldn't notice a future addition of another name for
Vendor ID 0x12ae, either by mistake or via acquisition of Alteon.
We want to know about either one so we can avoid collisions with
Device IDs used by Alteon.
prev parent reply other threads:[~2026-04-03 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 18:30 [PATCH net-next] eth: remove the driver for acenic / tigon1&2 Jakub Kicinski
2026-04-03 8:48 ` Greg KH
2026-04-03 13:34 ` Jes Sorensen
2026-04-03 13:50 ` Gary Guo
2026-04-03 15:40 ` Bjorn Helgaas
2026-04-03 19:33 ` Jakub Kicinski
2026-04-03 19:56 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403195657.GA351015@bhelgaas \
--to=helgaas@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=a.hindborg@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=aliceryhl@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=ardb@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=chleroy@kernel.org \
--cc=dakr@kernel.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dong100@mucse.com \
--cc=ebiggers@google.com \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=gary@garyguo.net \
--cc=geert@linux-m68k.org \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jes@trained-monkey.org \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=kernel@xen0n.name \
--cc=kshk@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lirongqing@baidu.com \
--cc=loongarch@lists.linux.dev \
--cc=lossin@kernel.org \
--cc=maddy@linux.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=pabeni@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tiwai@suse.de \
--cc=tmgross@umich.edu \
--cc=tsbogend@alpha.franken.de \
--cc=tytso@mit.edu \
--cc=vadim.fedorenko@linux.dev \
--cc=vineethr@linux.ibm.com \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox