From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E462624E4C3; Fri, 3 Apr 2026 19:56:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775246219; cv=none; b=YBIl9CO5oDAYKr5bqdmNKX6u14FYJlhRrBIxzscrA5QVPncWKsnj7/WNOfJWvuTd4AcabNiMEpeFu3KQ8sBkPCzwqeih8hPiPvJ9aT99J+mCXxJYyrF7iCj8s5R0VNXDGhkOrYvLprn3HHJNjL+4GwiIvHkFjAYgYUbvUz/2xrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775246219; c=relaxed/simple; bh=i/moDq0DGqe89rhWcnbMfpd1fOs4JQ4tDR5Rad9XOKs=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=ZzUC2LX+ZwfggTlMD8nrimIaYk/jktw1PeeP2CpAbjiJjaH3EOSt0X4+A+wOLjVzo3jWtX+Blqi6vmRqn4x0fIgXt5TtbeEzIDJndXyhinGGkG2wQyVFL54zqbT2/yMNdt4Be+sH/tSYB18LWAEDXj7n8GsSHb7rQ/bg6Lp12j8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q72QCnJt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q72QCnJt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44607C19424; Fri, 3 Apr 2026 19:56:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775246218; bh=i/moDq0DGqe89rhWcnbMfpd1fOs4JQ4tDR5Rad9XOKs=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Q72QCnJtolrdfAl0t++TuTiC3koOuaEji+ymU3jHbtTupWzOWgx5WN5Lvu1MtXSSb Ie8MNVEuYsSN36so1VJfqCVexa6J7Sf38JcGC+sMePAhc3zkXf+1dPjtVakGk1eYAX I6DGKKg36VNsfeXCTDL6J4S5ACrui9iGS9YGQg1cAqYk/BQakA99RoDpQ/QHCPWwVZ lZdM3dNrIL1xr09McGG/bJM/cIa5AQl8vN4JyNMEfmX01ilaZ4zNyNCu6rI8EIi48c lSRZ3MZ1LMbY9yT25BafikuhDlIvA1DbyYoY7pAyQW6549UTysLsVRe3bEUW/ImAWU MgAQL3FzVSy0Q== Date: Fri, 3 Apr 2026 14:56:57 -0500 From: Bjorn Helgaas To: Jakub Kicinski Cc: Gary Guo , davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, jes@trained-monkey.org, chenhuacai@kernel.org, kernel@xen0n.name, tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com, deller@gmx.de, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, bhelgaas@google.com, dakr@kernel.org, kwilczynski@kernel.org, ojeda@kernel.org, boqun@kernel.org, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, ebiggers@google.com, ardb@kernel.org, tiwai@suse.de, tytso@mit.edu, enelsonmoore@gmail.com, martin.petersen@oracle.com, jirislaby@kernel.org, gregkh@linuxfoundation.org, geert@linux-m68k.org, herbert@gondor.apana.org.au, vineethr@linux.ibm.com, lirongqing@baidu.com, kshk@linux.ibm.com, vadim.fedorenko@linux.dev, dong100@mucse.com, wangruikang@iscas.ac.cn, hkallweit1@gmail.com, kees@kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH net-next] eth: remove the driver for acenic / tigon1&2 Message-ID: <20260403195657.GA351015@bhelgaas> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260403123329.42bed564@kernel.org> On Fri, Apr 03, 2026 at 12:33:29PM -0700, Jakub Kicinski wrote: > On Fri, 3 Apr 2026 10:40:10 -0500 Bjorn Helgaas wrote: > > > > -#define PCI_VENDOR_ID_ALTEON 0x12ae > > > > - > > > > #define PCI_SUBVENDOR_ID_CONNECT_TECH 0x12c4 > > > > #define PCI_SUBDEVICE_ID_CONNECT_TECH_BH8_232 0x0001 > > > > #define PCI_SUBDEVICE_ID_CONNECT_TECH_BH4_232 0x0002 > > > > > Does the PCI ID needs to be removed? There was a similar change that > > > I recalled and the discussion eventually leads to ID not being > > > removed. > > > https://lore.kernel.org/all/20260123033233.16906-1-enelsonmoore@gmail.com/ > > > > I don't think there is value in removing the PCI_VENDOR_ID_ALTEON > > definition. > > Do you want me to respin the patch? "there is no value" is probably fair > but also there's no value in keeping it so LMK if you want a respin.. I think there is a little value in keeping it. Removing PCI_VENDOR_ID_ALTEON: - makes future backports slightly harder, e.g., we remove PCI_VENDOR_ID_ALTEON, then add a new definition like Vendor ID 0x12af, then backport the new definition, and the backport doesn't apply cleanly because the context doesn't match. - means we wouldn't notice a future addition of another name for Vendor ID 0x12ae, either by mistake or via acquisition of Alteon. We want to know about either one so we can avoid collisions with Device IDs used by Alteon.