From: Christian Benton <t1bur0n.kernel.org@protonmail.ch>
To: ojeda@kernel.org
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
aliceryhl@google.com, lossin@kernel.org,
Christian Benton <t1bur0n.kernel.org@protonmail.ch>
Subject: [PATCH 1/2] rust: list: fix SAFETY comment in List::remove
Date: Fri, 03 Apr 2026 22:08:15 +0000 [thread overview]
Message-ID: <20260403220751.15374-2-t1bur0n.kernel.org@protonmail.ch> (raw)
In-Reply-To: <20260403220751.15374-1-t1bur0n.kernel.org@protonmail.ch>
The SAFETY comment for the call to ListLinks::fields in List::remove
was left as TODO. Fill it in: the call is safe because T::view_links
returns a reference to the ListLinks field of item, and references are
always valid and non-dangling.
Signed-off-by: Christian Benton <t1bur0n.kernel.org@protonmail.ch>
---
rust/kernel/list.rs | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/rust/kernel/list.rs b/rust/kernel/list.rs
index 406e3a028..b5705af43 100644
--- a/rust/kernel/list.rs
+++ b/rust/kernel/list.rs
@@ -599,7 +599,9 @@ pub fn pop_front(&mut self) -> Option<ListArc<T, ID>> {
///
/// `item` must not be in a different linked list (with the same id).
pub unsafe fn remove(&mut self, item: &T) -> Option<ListArc<T, ID>> {
- // SAFETY: TODO.
+ // SAFETY: `T::view_links` returns a reference to the `ListLinks` field of `item`.
+ // References are always valid and non-dangling, so converting to a raw pointer
+ // via `ListLinks::fields` is sound.
let mut item = unsafe { ListLinks::fields(T::view_links(item)) };
// SAFETY: The user provided a reference, and reference are never dangling.
//
--
2.53.0
next prev parent reply other threads:[~2026-04-03 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 22:08 [PATCH 0/2] rust: list: fix incomplete SAFETY comments in list implementation Christian Benton
2026-04-03 22:08 ` Christian Benton [this message]
2026-04-07 8:15 ` [PATCH 1/2] rust: list: fix SAFETY comment in List::remove Alice Ryhl
2026-04-07 11:56 ` Gary Guo
2026-04-03 22:08 ` [PATCH 2/2] rust: list: fix SAFETY comments in impl_list_item_mod Christian Benton
2026-04-07 8:18 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403220751.15374-2-t1bur0n.kernel.org@protonmail.ch \
--to=t1bur0n.kernel.org@protonmail.ch \
--cc=aliceryhl@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox