From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A969933FE36 for ; Thu, 23 Apr 2026 14:31:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776954696; cv=none; b=rOGHV1qXoDKc584IcsLYRZoBwKjTV/Gg75s7zZE03Rk3SviPap5FDE7iSILqzLSknujyDDRRyG8JT3CQZK8bHqpyZ0NZcpyH7NwKGxWGrFRHW43k1SQb4eTeXwufRnmTLSYajnDGmzUm/n84szMmK0FMULodmONelPruGpOOYWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776954696; c=relaxed/simple; bh=FmhAV4iScOWFJVEpHXVI5bKYdUIRPJiAT6DmiyWON/A=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Xn58ApqYtBtnTEjWrewijnUg2/FbxIvSyYOwDTqieBGKfZ9QSlLNBpuGXgZz/GjTLhYG7TIuo0RmFIAHB72XnXNLOGP1m0yH+c7WNA72nDRjehr0SfyFAed5C+1iqR3o2tnrgDg3YZZPByUYugYRqBxsdoUvpPCJfaS54XAHQMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=C6o6/Q3H; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="C6o6/Q3H" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3E306240101 for ; Thu, 23 Apr 2026 16:31:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=2017; t=1776954688; bh=9bZZq+4QIXN2oIp+v4jgsDqu4HEpsVLwT810aulFwIw=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:To:Cc:Autocrypt:OpenPGP:From; b=C6o6/Q3H5TTc8+cXdjo1gLV/DRjRWU77c9Oi5ENofePO7dUdsNBpQumelX3Fo+5i2 H5CIR+ClKFlL+eQJaor0gIleVoqwbFF4HqSS1wDYJSqgUJk+EZplxtKXk3c5XVMjlL T3DAqs7E/LFeO7E2KSifcWf/ilnc16lnp+pmngdDba4QWlGxiXGHOc2YpoNholWju1 GBCuBYDdXwPHRQ9HbuRwaHQiVaHsdpp9QS/Thew2DT9WnqJO5uNc6WkGJXUqMYY4Se kvL2rRDkrj3hMBd0wN2niJ8IJo3PVA6a75Qxica6364qOFhuH67shPyo+94BCh1eIa FwJhH7jJ7Z42w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4g1dnM34jMz9rxK; Thu, 23 Apr 2026 16:31:19 +0200 (CEST) From: Markus Probst Subject: [PATCH v9 0/2] Introduce Synology Microp driver Date: Thu, 23 Apr 2026 14:31:22 +0000 Message-Id: <20260423-synology_microp_initial-v9-0-4a8533f87e07@posteo.de> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIACkt6mkC/4XQy27CMBAF0F9BWdfIj/Erq/5HVSHHHoMlSGgco iLEv9dAJdJUaZdj6R7fmUuVsU+Yq3p1qXocU05dWwb7sqr8zrVbJCmUueKUKyqoIvncdvtue94 cku+74ya1aUhuT2jUwXndaLCqKuljjzF93uW398fc48epfDA8Hp9+vSq6ZJxp0p/ysCmVAo4EU YJhaKmRvh5lNa30HWEMHpE9hkyclTZqz6OOth6ZuCUal5H47nBIQ70a9ZpWtzK7lIeuP9+3Htm 9zb8LjoxQEn2MGFABGP967PKA3Trg3Rz51DHLDi+OFcZaJaJgXs4dMXGYWHZEcVxQzoMSjlM2d 2DicLrsQHEocBFCY4R3MHfk1LHLjiwO174xtAlR2l991NMBKpcddetjYkDQ0Chv546eOIwtO/p 2ZycctYC6nGjumInz131McbQF5SzjAD/3ul6vX3zq6LJDAwAA X-Change-ID: 20260306-synology_microp_initial-0f7dac7b7496 To: Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Lee Jones , Pavel Machek , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman Cc: platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=5421; i=markus.probst@posteo.de; h=from:subject:message-id; bh=FmhAV4iScOWFJVEpHXVI5bKYdUIRPJiAT6DmiyWON/A=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBp6i02P0R5lebYhUe1FY4gkM4pgdmDLdpv2j8L1 1kbJmO6FUOJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaeotNhsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9IENg//ZTjefKIb/tsS8X/cuZzl9m03S576AI6 O3RrYIwAR9SNTBudk0IP6GaXSfAUGDvTXsNC9LqU9zkptet6EMjP5DL53GJWIoBdVI8x/7ebjjS qyv0gi0qqSrORQKLUdFEQ9IJIQvBcwATMit+oWLP52dTnno+1NPYN1QEm6j6/1u/ThVhjnYDv83 QVRT7b0aRUe/1te48FeXSDPGQOwU1S2qdIfuDtoJHjlbL8mtU1I+fOitPmQqh+/FhenXocRA2Vm aflO4nUUPVRkmFyzDUYjkvAhJ6DFax4OwMrlP593tEmgSnn39PU9UB05pD3FIohKAZOK8PwQ4kF 80q5bMGrkUSyzw9v4q5CLKwrqaaFcd1Llia/9X9Jm2hcajiARUCAiKejOAfzSuo3G7zks7N93Pg Gi4dlHbgTrCvIQz2tOQIgDBivJvQli3mvxxIeWv0u5zMpjMhs9gx5oiPAtjE4ff5R6N7/tZp5CI heGyA8uCln5tfY+xZzIXTtaJmivLaQ/2kGFzynwqYM49XS9XMmTK/sYIb9KZtvyl9fQ6NW105J2 qFrtCyo9DfxWHC0WvpAwlXAnTkeOYeFsTqKHwLdafEfJLt7sHkl/ycclPFImH8kgpOZ7/fkbFvC pHYttLhoTR0k85RuBeW5uDE5fAL/b9Y0INI1UsKUeqVfcPDay+FE= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Synology uses a microcontroller in their NAS devices connected to a serial port to control certain LEDs, fan speeds, a beeper, to handle proper shutdown and restart, buttons and fan failures. This patch series depends on the rust led abstraction [1] and the rust serdev abstraction [2]. This is only a initial version of the driver able to control LEDs. The following rust abstractions would be required, to implement the remaining features: - hwmon (include/linux/hwmon.h) - input (include/linux/input.h) - sysoff handler + hardware protection shutdown (include/linux/reboot.h) [1] https://lore.kernel.org/rust-for-linux/20260329-rust_leds-v13-0-21a599c5b2d1@posteo.de/ [2] https://lore.kernel.org/rust-for-linux/20260420-rust_serdev-v5-0-57e8ba0519f3@posteo.de/ Signed-off-by: Markus Probst --- Changes in v9: - separate fallback and front compatibles in dt schema - remove front compatibles from of id table, if all functionality is by covered by the fallback - remove TODO file - add platform-driver-x86@vger.kernel.org to Maintainers file entry - use `Delta` type in `BLINK_DELAY` const - Link to v8: https://patch.msgid.link/20260420-synology_microp_initial-v8-0-7946a9124491@posteo.de Changes in v8: - removed unnecessary Copy and Clone derive - added `BLINK_DELAY` constant - added compatible id fallbacks - moved dt schema patch before the driver - added ds411p - Link to v7: https://lore.kernel.org/r/20260411-synology_microp_initial-v7-0-9a3a094e763a@posteo.de Changes in v7: - remove list of compatible ids from commit msg - explain what makes the different models not compatible in the commit msg - remove unnecessary examples - Link to v6: https://lore.kernel.org/r/20260405-synology_microp_initial-v6-0-08fde474b6c9@posteo.de Changes in v6: - moved devicetree bindings patch at the end of the set - remove several patches - move of id table from model.rs to synology_microp.rs - remove the model! macro - use if blocks in devicetree schema to narrow down the fan-failure-gpios property - add multiple devicetree examples to test if blocks - Link to v5: https://lore.kernel.org/r/20260329-synology_microp_initial-v5-0-27cb80bdf591@posteo.de Changes in v5: - add esata led support - use different compatible for each model - add visibility modifier to of_device_table macro - fix match data missing when using PRP0001 - Link to v4: https://lore.kernel.org/r/20260320-synology_microp_initial-v4-0-0423ddb83ca4@posteo.de Changes in v4: - convert to monolithic driver and moved it into drivers/platform - removed mfd rust abstraction - moved dt-bindings to embedded-controller - Link to v3: https://lore.kernel.org/r/20260313-synology_microp_initial-v3-0-ad6ac463a201@posteo.de Changes in v3: - remove `default n` from Kconfig entry, as n is the default already. - select RUST_SERIAL_DEV_BUS_ABSTRACTIONS in Kconfig - add mfd rust abstraction - split core and led parts into their own driver. It should now be considered a MFD device. - split led part of dt binding into its own file - Link to v2: https://lore.kernel.org/r/20260308-synology_microp_initial-v2-0-9389963f31c5@posteo.de Changes in v2: - fix missing tabs in MAINTAINERS file - remove word binding from patch subject - add missing signed-off-by - add missing help entry in Kconfig - add missing spdx license headers - remove no-check{,-cpu}-fan properties from the dt-bindings and replace them with the check_fan module parameter - use patternProperties for leds in dt-bindings - license dt-binding as GPL-2.0-only OR BSD-2-Clause - move driver from staging tree into mfd tree and mark it as work in progress inside Kconfig - only register alert and usb led if fwnode is present - Link to v1: https://lore.kernel.org/r/20260306-synology_microp_initial-v1-0-fcffede6448c@posteo.de --- Markus Probst (2): dt-bindings: embedded-controller: Add synology microp devices platform: Add initial synology microp driver .../synology,ds918p-microp.yaml | 101 ++++++++ MAINTAINERS | 7 + drivers/platform/Kconfig | 2 + drivers/platform/Makefile | 1 + drivers/platform/synology_microp/Kconfig | 13 + drivers/platform/synology_microp/Makefile | 3 + drivers/platform/synology_microp/command.rs | 54 ++++ drivers/platform/synology_microp/led.rs | 282 +++++++++++++++++++++ drivers/platform/synology_microp/model.rs | 49 ++++ .../platform/synology_microp/synology_microp.rs | 90 +++++++ 10 files changed, 602 insertions(+) --- base-commit: 3131ff5a117498bb4b9db3a238bb311cbf8383ce change-id: 20260306-synology_microp_initial-0f7dac7b7496 prerequisite-change-id: 20251217-rust_serdev-ee5481e9085c:v5 prerequisite-patch-id: 52b17274481cc770c257d8f95335293eca32a2c5 prerequisite-patch-id: eec47e5051640d08bcd34a9670b98804449cad52 prerequisite-patch-id: 764976150be0936469334e0f4ab631e994a262a6 prerequisite-patch-id: d0686cf451ef899a06d468adfba51ccd84e6ff98 prerequisite-change-id: 20251114-rust_leds-a959f7c2f7f9:v13 prerequisite-patch-id: 818700f22dcb9676157c985f82762d7c607b861e prerequisite-patch-id: b15ffa7d95d9260151bfb116b259c4473f721c82 prerequisite-patch-id: 8c47e0d107530f577a1be0b79f8ee791f95d3cbe