public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Hsiu Che Yu <yu.whisper.personal@gmail.com>
To: "Andreas Hindborg" <a.hindborg@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>
Cc: linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	Hsiu Che Yu <yu.whisper.personal@gmail.com>
Subject: [PATCH] rust: block: fix comment referring to states by wrong labels
Date: Tue, 28 Apr 2026 15:24:54 +0800	[thread overview]
Message-ID: <20260428-fix-docs-mq-req-v1-1-260079853836@gmail.com> (raw)

The comment in `Request` describing the four ownership states referred
to states 2 and 3 as "B" and "C", which are inconsistent with the
numbering scheme used throughout the same comment block.

Update the labels to use "2" and "3" to match the existing numbered list.

Fixes: a307bf1db5448 ("rust: block: convert `block::mq` to use `Refcount`")
Signed-off-by: Hsiu Che Yu <yu.whisper.personal@gmail.com>
---
 rust/kernel/block/mq/request.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/block/mq/request.rs b/rust/kernel/block/mq/request.rs
index ce3e30c81cb5..75d3fdf896e0 100644
--- a/rust/kernel/block/mq/request.rs
+++ b/rust/kernel/block/mq/request.rs
@@ -39,7 +39,7 @@
 /// back ownership to the block layer.
 ///
 /// Note that the driver can still obtain new `ARef` even if there is no `ARef`s in existence by
-/// using `tag_to_rq`, hence the need to distinguish B and C.
+/// using `tag_to_rq`, hence the need to distinguish 2 and 3.
 ///
 /// The states are tracked through the private `refcount` field of
 /// `RequestDataWrapper`. This structure lives in the private data area of the C

---
base-commit: b4e07588e743c989499ca24d49e752c074924a9a
change-id: 20260428-fix-docs-mq-req-d2a0fe1b6471

Best regards,
--  
Hsiu Che Yu <yu.whisper.personal@gmail.com>


             reply	other threads:[~2026-04-28  7:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <u8w2aT8RMDhNK-zCkHKofFcml9mE8ndgtCnpwTrMWy6Kby41yC9ODSFCSKRZF8QahViSy2ANwHyurTUyVlgroA==@protonmail.internalid>
2026-04-28  7:24 ` Hsiu Che Yu [this message]
2026-04-28 11:42   ` [PATCH] rust: block: fix comment referring to states by wrong labels Miguel Ojeda
2026-04-28 11:48     ` Hsiu Che Yu
2026-04-29 10:17   ` Andreas Hindborg
2026-04-29 10:35     ` Hsiu Che Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260428-fix-docs-mq-req-v1-1-260079853836@gmail.com \
    --to=yu.whisper.personal@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox