From: Janne Grunau <j@jannau.net>
To: Gary Guo <gary@garyguo.net>
Cc: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
"Sasha Finkelstein" <k@chaosmail.tech>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH RFC] Fail the build on RUST=y and RUST_IS_AVAILABLE=n
Date: Sun, 10 May 2026 19:56:17 +0200 [thread overview]
Message-ID: <20260510175617.GA118456@robin.jannau.net> (raw)
In-Reply-To: <DIF492AU2WJF.359GZYTFSWM1I@garyguo.net>
On Sun, May 10, 2026 at 04:53:15PM +0100, Gary Guo wrote:
> On Sun May 10, 2026 at 2:45 PM BST, Miguel Ojeda wrote:
> > On Sun, May 10, 2026 at 3:36 PM Sasha Finkelstein <k@chaosmail.tech> wrote:
> >>
> >> The current approach of silently disabling all rust drivers if the
> >> toolchain is missing results in users that try to compile their own
> >> kernels getting a "successful" build and then being confused about where
> >> did their drivers go. In comparison, missing openssl results in a build
> >> failure, not a disappearance of everything that depends on it.
> >
> > Yeah, it is quite confusing (though it was done on purpose).
> >
> > Personally, I think it may be time to finally change it.
>
> I believe the original reason for doing so is that people can use allyesconfig
> and it'll disable all Rust modules if they don't have a working Rust compiler.
>
> Do you intend to change it so that allyesconfig needs Rust, or is there a
> different mechanism to make allyesconfig ignore Rust modules?
One could argue that since commit 9fa7153c31a3 ("rust: conclude the Rust
experiment") RUST belongs in the allyesconfig.
If that's valid the patch misses to add "depends" on the architectures
which have support Rust support in the kernel.
Janne
next prev parent reply other threads:[~2026-05-10 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 13:36 [PATCH RFC] Fail the build on RUST=y and RUST_IS_AVAILABLE=n Sasha Finkelstein
2026-05-10 13:45 ` Miguel Ojeda
2026-05-10 15:53 ` Gary Guo
2026-05-10 17:56 ` Janne Grunau [this message]
2026-05-10 18:15 ` Sasha Finkelstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260510175617.GA118456@robin.jannau.net \
--to=j@jannau.net \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=k@chaosmail.tech \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox