From: "Onur Özkan" <work@onurozkan.dev>
To: Xiaobo Liu <cppcoffee@gmail.com>
Cc: rust-for-linux@vger.kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org, mcgrof@kernel.org,
petr.pavlu@suse.com, da.gomez@kernel.org,
samitolvanen@google.com, atomlin@atomlin.com, ojeda@kernel.org,
boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com,
lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com,
tmgross@umich.edu, dakr@kernel.org
Subject: Re: [PATCH] rust: kernel: module_param: replace pr_warn with pr_warn_once
Date: Mon, 18 May 2026 14:18:02 +0300 [thread overview]
Message-ID: <20260518111805.65576-1-work@onurozkan.dev> (raw)
In-Reply-To: <20260518104735.34906-1-cppcoffee@gmail.com>
On Mon, 18 May 2026 18:47:35 +0800
Xiaobo Liu <cppcoffee@gmail.com> wrote:
> Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
> ---
You need to write description for the change.
Onur
> rust/kernel/module_param.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/rust/kernel/module_param.rs b/rust/kernel/module_param.rs
> index 6a8a7a875..fedb709fa 100644
> --- a/rust/kernel/module_param.rs
> +++ b/rust/kernel/module_param.rs
> @@ -62,8 +62,8 @@ pub trait ModuleParam: Sized + Copy {
> // NOTE: If we start supporting arguments without values, val _is_ allowed
> // to be null here.
> if val.is_null() {
> - // TODO: Use pr_warn_once available.
> - crate::pr_warn!("Null pointer passed to `module_param::set_param`");
> + crate::pr_warn_once!("Null pointer passed to `module_param::set_param`");
> return EINVAL.to_errno();
> }
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-05-18 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 10:47 [PATCH] rust: kernel: module_param: replace pr_warn with pr_warn_once Xiaobo Liu
2026-05-18 11:18 ` Onur Özkan [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-18 13:40 Xiaobo Liu
2026-05-18 13:41 Xiaobo Liu
2026-05-18 17:37 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518111805.65576-1-work@onurozkan.dev \
--to=work@onurozkan.dev \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=atomlin@atomlin.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=cppcoffee@gmail.com \
--cc=da.gomez@kernel.org \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mcgrof@kernel.org \
--cc=ojeda@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox