Re: [PATCH v2 3/5] rust: miscdevice: remove redundant imports

["Onur Özkan" <work@onurozkan.dev>]

On Wed, 20 May 2026 10:40:10 +0800
Alvin Sun <alvin.sun@linux.dev> wrote:

> Drop `Error`, `Result`, `Pin`, `c_int`, `c_long`, `c_uint`, and
> `c_ulong` imports already provided by `kernel::prelude`.
> 
> Signed-off-by: Alvin Sun <alvin.sun@linux.dev>

Reviewed-by: Onur Özkan <work@onurozkan.dev>

> ---
>  rust/kernel/miscdevice.rs | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
> index 05a6b6b9770f2..83ce50def5ac9 100644
> --- a/rust/kernel/miscdevice.rs
> +++ b/rust/kernel/miscdevice.rs
> @@ -13,16 +13,8 @@
>      device::Device,
>      error::{
>          to_result,
> -        Error,
> -        Result,
>          VTABLE_DEFAULT_ERROR, //
>      },
> -    ffi::{
> -        c_int,
> -        c_long,
> -        c_uint,
> -        c_ulong, //
> -    },
>      fs::{
>          File,
>          Kiocb, //
> @@ -39,10 +31,7 @@
>          Opaque, //
>      },
>  };
> -use core::{
> -    marker::PhantomData,
> -    pin::Pin, //
> -};
> +use core::marker::PhantomData;
>  
>  /// Options for creating a misc device.
>  #[derive(Copy, Clone)]
> 
> -- 
> 2.43.0
> 
>