From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7087A305666 for ; Tue, 26 May 2026 06:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779777845; cv=none; b=sFUDlK8NTXS+yk5NuRXdDH0LUiW3ze1tYD41N1YkxQxE52ggcoM1xCBlAGrAQnsfArf2FMzQ05TJVV2Q3QJ2YCCyj+34bDg0Zj6qhUDzEPAuPsViQ3RJaoKuRd64BH+b6zFfqytVeTQqEhUYndKApk+toZb/ub1kyRwTlwJCjFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779777845; c=relaxed/simple; bh=Khh3bfBuey5JL1UfnZwr3BRsPXoQ7q7n4zB2lZK45HA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=deY7cfi4+J1A80KqcPzztwRL0hqjvA5duv1HwU/Se539dwb8FXqIw1DtpWrOJlNZ2LlJNw4japkK0RPbdgBekBcAzuaasXz2kiE8qTFZfbGOOfj9x6RvPTwZivLKhfBmwDrY5Z6RxcjyWfDfM41G5cR0/GVvL5T7xPWuJcW3IRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=YbxQQRYr; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="YbxQQRYr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1779777841; bh=Khh3bfBuey5JL1UfnZwr3BRsPXoQ7q7n4zB2lZK45HA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YbxQQRYrS1TTHt5h95oURB7jRAztrTGEmWzkiILJ9ODjOjVcQi0vgEFT8RQ+ck1V/ d0bSrsnTCczXVTwzmGfsMJoN9w3E/XggA4MAaGRr4umlh8zaXHRxHxX2JMxRj7Bzw0 YtjOpSZUN7y8KxzCAse03pE2S48pKgOWaDe9h4FwG1W4cNbYUgtJ3aPWxvA5o/wLHu pU+eB+GF7l4xS4CB4ZArnyydVYMVAcl1o3Fv5lNZB2GhlfjrGvF3zMljHcsuhneBYN rtthG/UusqboSgJM8u0+vt+9DgGly4t2tVALiik6bOuKEnj5jDFxR3pLvWwr/WuudY n9zBL1YrBDP1Q== Received: from fedora (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 2A19B17E0443; Tue, 26 May 2026 08:44:01 +0200 (CEST) Date: Tue, 26 May 2026 08:43:58 +0200 From: Boris Brezillon To: Danilo Krummrich Cc: aliceryhl@google.com, daniel.almeida@collabora.com, deborah.brouwer@collabora.com, gary@garyguo.net, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH 1/2] gpu: drm: tyr: separate driver type from driver data Message-ID: <20260526084358.3fb40cff@fedora> In-Reply-To: <20260525230152.277820-2-dakr@kernel.org> References: <20260525230152.277820-1-dakr@kernel.org> <20260525230152.277820-2-dakr@kernel.org> Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 26 May 2026 01:01:43 +0200 Danilo Krummrich wrote: > Introduce TyrPlatformDriver as a unit struct for the platform::Driver > trait implementation and keep TyrPlatformDriverData for the private > driver data. > > Signed-off-by: Danilo Krummrich Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/tyr/driver.rs | 10 ++++++---- > drivers/gpu/drm/tyr/tyr.rs | 4 ++-- > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs > index 2224fdb20a51..5f4c484f671f 100644 > --- a/drivers/gpu/drm/tyr/driver.rs > +++ b/drivers/gpu/drm/tyr/driver.rs > @@ -51,6 +51,8 @@ > /// Convenience type alias for the DRM device type for this driver. > pub(crate) type TyrDrmDevice = drm::Device; > > +pub(crate) struct TyrPlatformDriver; > + > #[pin_data(PinnedDrop)] > pub(crate) struct TyrPlatformDriverData { > _device: ARef, > @@ -93,22 +95,22 @@ fn issue_soft_reset(dev: &Device, iomem: &Devres) -> Result { > kernel::of_device_table!( > OF_TABLE, > MODULE_OF_TABLE, > - ::IdInfo, > + ::IdInfo, > [ > (of::DeviceId::new(c"rockchip,rk3588-mali"), ()), > (of::DeviceId::new(c"arm,mali-valhall-csf"), ()) > ] > ); > > -impl platform::Driver for TyrPlatformDriverData { > +impl platform::Driver for TyrPlatformDriver { > type IdInfo = (); > - type Data<'bound> = Self; > + type Data<'bound> = TyrPlatformDriverData; > const OF_ID_TABLE: Option> = Some(&OF_TABLE); > > fn probe<'bound>( > pdev: &'bound platform::Device>, > _info: Option<&'bound Self::IdInfo>, > - ) -> impl PinInit + 'bound { > + ) -> impl PinInit, Error> + 'bound { > let core_clk = Clk::get(pdev.as_ref(), Some(c"core"))?; > let stacks_clk = OptionalClk::get(pdev.as_ref(), Some(c"stacks"))?; > let coregroup_clk = OptionalClk::get(pdev.as_ref(), Some(c"coregroup"))?; > diff --git a/drivers/gpu/drm/tyr/tyr.rs b/drivers/gpu/drm/tyr/tyr.rs > index 9432ddd6b5b8..95cda7b0962f 100644 > --- a/drivers/gpu/drm/tyr/tyr.rs > +++ b/drivers/gpu/drm/tyr/tyr.rs > @@ -5,7 +5,7 @@ > //! The name "Tyr" is inspired by Norse mythology, reflecting Arm's tradition of > //! naming their GPUs after Nordic mythological figures and places. > > -use crate::driver::TyrPlatformDriverData; > +use crate::driver::TyrPlatformDriver; > > mod driver; > mod file; > @@ -14,7 +14,7 @@ > mod regs; > > kernel::module_platform_driver! { > - type: TyrPlatformDriverData, > + type: TyrPlatformDriver, > name: "tyr", > authors: ["The Tyr driver authors"], > description: "Arm Mali Tyr DRM driver",