Rust for Linux List
 help / color / mirror / Atom feed
From: Joel Kamminga <contact@jkam.dev>
To: miguel.ojeda.sandonis@gmail.com
Cc: a.hindborg@kernel.org, aliceryhl@google.com,
	bjorn3_gh@protonmail.com, boqun@kernel.org, contact@jkam.dev,
	dakr@kernel.org, gary@garyguo.net, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, lossin@kernel.org,
	nathan@kernel.org, nsc@kernel.org, ojeda@kernel.org,
	rust-for-linux@vger.kernel.org, tmgross@umich.edu
Subject: Re: [PATCH v3] kbuild: rust: make `*.long-type-*.txt` a target for cleanup
Date: Sun, 31 May 2026 22:23:04 -0600	[thread overview]
Message-ID: <20260601042304.73316-1-contact@jkam.dev> (raw)
In-Reply-To: <CANiq72=huc=AfjBRYUsoJY1hSvB8W6CvnUh7g2G4rt98XYmxYw@mail.gmail.com>

On 2026-05-31 00:45, Miguel Ojeda wrote:
> In general, please add a changelog after the `---` line. Otherwise,
> reviewers need to manually inspect the patch to see what has changed,
> if anything.
> 
> For instance, I see you changed the title, but the commit message
> seems identical. Was there a reason to not change it?

Hi!

Thanks for the comments and tips. Just for future reference for myself,
in regards to applying changes strictly to the metadata of the patch
(i.e. adding a changelog but leaving the actual code unchanged), is it
preferred to just resend the same version of the patch with the
changelog added instead of creating a whole new version? That was the
impression I got reading through some earlier patches, but seeing as
I've been creating new patch versions and haven't been told to do
otherwise, I figured I'd double check.

Thanks,

Joel

  reply	other threads:[~2026-06-01  4:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 18:49 [PATCH v3] kbuild: rust: make `*.long-type-*.txt` a target for cleanup Joel Kamminga
2026-05-31  6:45 ` Miguel Ojeda
2026-06-01  4:23   ` Joel Kamminga [this message]
2026-06-01  5:08     ` Miguel Ojeda
2026-06-01 16:50 ` Joel Kamminga
2026-06-01 19:23   ` Nathan Chancellor
2026-06-02  7:36     ` Miguel Ojeda
2026-06-02  8:15 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260601042304.73316-1-contact@jkam.dev \
    --to=contact@jkam.dev \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox