From: Miguel Ojeda <ojeda@kernel.org>
To: gary@garyguo.net
Cc: a.hindborg@kernel.org, acourbot@nvidia.com, airlied@gmail.com,
aliceryhl@google.com, bjorn3_gh@protonmail.com, boqun@kernel.org,
dakr@kernel.org, daniel.almeida@collabora.com,
dri-devel@lists.freedesktop.org, driver-core@lists.linux.dev,
fujita.tomonori@gmail.com, linux-kernel@vger.kernel.org,
longman@redhat.com, lossin@kernel.org, mark.rutland@arm.com,
miguel.ojeda.sandonis@gmail.com, mingo@redhat.com,
netdev@vger.kernel.org, nova-gpu@lists.linux.dev,
ojeda@kernel.org, peterz@infradead.org,
rust-for-linux@vger.kernel.org, simona@ffwll.ch,
tamird@kernel.org, tmgross@umich.edu, will@kernel.org,
yury.norov@gmail.com
Subject: Re: [PATCH v4] rust: make `build_assert` module the home of related macros
Date: Wed, 10 Jun 2026 09:29:47 +0200 [thread overview]
Message-ID: <20260610072947.338278-1-ojeda@kernel.org> (raw)
In-Reply-To: <DJ4Q5J5OILOX.1KCPFIVUFN2VV@garyguo.net>
On Tue, 09 Jun 2026 19:19:42 +0100 Gary Guo <gary@garyguo.net> wrote:
>
> I think I just kept it as is when rebasing. It's file to have them grouped in
> the crate to.
Thanks for confirming!
> This one is using size_of, align_of, c_void which are all in prelude. However it
> looks like I forgot to actually remove these imports in the last version, and I
> didn't change it during rebase.
Ah, I see, makes sense.
> Are you okay with fixing during applying, or do you want me to send a new version?
I did it on my side. I also tweaked a couple more bits: they were already
`no_inline`, and I noted that they sadly do not appear in the prelude anymore,
but the change looks fine and that may be more of a `rustdoc`-side issue or
design choice.
Cheers,
Miguel
next prev parent reply other threads:[~2026-06-10 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 14:26 [PATCH v4] rust: make `build_assert` module the home of related macros Gary Guo
2026-06-09 17:19 ` Miguel Ojeda
2026-06-09 18:19 ` Gary Guo
2026-06-10 7:29 ` Miguel Ojeda [this message]
2026-06-10 10:01 ` Gary Guo
2026-06-10 7:30 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610072947.338278-1-ojeda@kernel.org \
--to=ojeda@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=lossin@kernel.org \
--cc=mark.rutland@arm.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox