Rust for Linux List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Keshav Verma <iganschel@gmail.com>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
	"Carlos Llamas" <cmllamas@google.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust_binder: check context manager before creating node
Date: Thu, 18 Jun 2026 13:28:45 +0200	[thread overview]
Message-ID: <2026061858-frugally-upload-17ab@gregkh> (raw)
In-Reply-To: <CAPE_3zLCOwqa8Yb21oAb8i9AHW-UPqW=+9848fUtuTKK6wAZDA@mail.gmail.com>

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Jun 18, 2026 at 04:49:31PM +0530, Keshav Verma wrote:
> Thanks, I will fix the line wrapping and add the appropriate Fixes tag in
> v2.

Also, you sent html email which the lists reject :(

> This can be triggered after the normal context manager has already been
> registered. A second process can open /dev/binder and call
> BINDER_SET_CONTEXT_MGR_EXT with a local BINDER_TYPE_BINDER object. The
> ioctl returns -EBUSY because the context manager already exists.
> 
> Repeating this with unique ptr/cookie values triggers the warning each time.
> 
> Since this is easy to trigger from userspace, should I drop the pr_warn!() from
> the check in v2 and just return -EBUSY there?

If userspace can trigger this, then please remove it so that it doesn't
cause a denial-of-service on the kernel log.

thanks,

greg k-h

  parent reply	other threads:[~2026-06-18 11:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 22:20 [PATCH] rust_binder: check context manager before creating node Keshav Verma
2026-06-18 10:27 ` Greg Kroah-Hartman
     [not found]   ` <CAPE_3zLCOwqa8Yb21oAb8i9AHW-UPqW=+9848fUtuTKK6wAZDA@mail.gmail.com>
2026-06-18 11:28     ` Greg Kroah-Hartman [this message]
2026-06-18 11:33     ` Miguel Ojeda
2026-06-18 11:52   ` Alice Ryhl
2026-06-18 12:12 ` [PATCH v2] " Keshav Verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026061858-frugally-upload-17ab@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=aliceryhl@google.com \
    --cc=arve@android.com \
    --cc=boqun@kernel.org \
    --cc=brauner@kernel.org \
    --cc=cmllamas@google.com \
    --cc=gary@garyguo.net \
    --cc=iganschel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox