From: Eliot Courtney <ecourtney@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Alice Ryhl <aliceryhl@google.com>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Benno Lossin <lossin@kernel.org>, Gary Guo <gary@garyguo.net>
Cc: John Hubbard <jhubbard@nvidia.com>,
Alistair Popple <apopple@nvidia.com>,
Timur Tabi <ttabi@nvidia.com>,
nova-gpu@lists.linux.dev, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
Eliot Courtney <ecourtney@nvidia.com>
Subject: [PATCH v2 07/10] gpu: nova-core: rename heap size field
Date: Fri, 03 Jul 2026 19:22:11 +0900 [thread overview]
Message-ID: <20260703-blackwell-fixes-v2-7-8e3d8bc32bb9@nvidia.com> (raw)
In-Reply-To: <20260703-blackwell-fixes-v2-0-8e3d8bc32bb9@nvidia.com>
This field is called non_wpr_heap_size everywhere else. Unify the name
to make it more obvious which heap it is.
Signed-off-by: Eliot Courtney <ecourtney@nvidia.com>
---
drivers/gpu/nova-core/fb.rs | 14 +++++++-------
drivers/gpu/nova-core/gsp/fw.rs | 8 ++++----
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/nova-core/fb.rs b/drivers/gpu/nova-core/fb.rs
index 5ffe66af282f..431828cad1a1 100644
--- a/drivers/gpu/nova-core/fb.rs
+++ b/drivers/gpu/nova-core/fb.rs
@@ -183,7 +183,7 @@ pub(crate) struct FbRanges {
/// WPR2 region range, starting with an instance of `GspFwWprMeta`.
pub(crate) wpr2: FbRange,
/// Non-WPR heap, located just below WPR2.
- pub(crate) heap: FbRange,
+ pub(crate) non_wpr_heap: FbRange,
/// Number of VF partitions.
pub(crate) vf_partition_count: u8,
/// PMU reserved memory size, in bytes.
@@ -272,9 +272,9 @@ fn new(chipset: Chipset, bar: Bar0<'_>, gsp_fw: &GspFirmware) -> Result<Self> {
FbRange(wpr2_addr..frts.end)
};
- let heap = {
- let heap_size = u64::from(hal.non_wpr_heap_size());
- FbRange(wpr2.start - heap_size..wpr2.start)
+ let non_wpr_heap = {
+ let non_wpr_heap_size = u64::from(hal.non_wpr_heap_size());
+ FbRange(wpr2.start - non_wpr_heap_size..wpr2.start)
};
Ok(Self {
@@ -285,7 +285,7 @@ fn new(chipset: Chipset, bar: Bar0<'_>, gsp_fw: &GspFirmware) -> Result<Self> {
elf,
wpr2_heap,
wpr2,
- heap,
+ non_wpr_heap,
vf_partition_count: 0,
pmu_reserved_size: hal.pmu_reserved_size(),
})
@@ -302,7 +302,7 @@ pub(crate) struct FbSizes {
/// WPR2 heap size, in bytes.
pub(crate) wpr2_heap_size: u64,
/// Non-WPR heap size, in bytes.
- pub(crate) heap_size: u64,
+ pub(crate) non_wpr_heap_size: u64,
/// PMU reserved memory size, in bytes.
pub(crate) pmu_reserved_size: u32,
/// Size reserved at the end of the framebuffer. This is architecture dependent and used to
@@ -323,7 +323,7 @@ fn new(chipset: Chipset, bar: Bar0<'_>) -> Result<Self> {
frts_size: hal.frts_size(),
wpr2_heap_size: gsp::LibosParams::from_chipset(chipset)
.wpr_heap_size(chipset, fb_size)?,
- heap_size: u64::from(hal.non_wpr_heap_size()),
+ non_wpr_heap_size: u64::from(hal.non_wpr_heap_size()),
pmu_reserved_size: hal.pmu_reserved_size(),
fb_end_reserved_size: hal.fb_end_reserved_size(),
vf_partition_count: 0,
diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw.rs
index 3b148147cb18..5a2fa1a4a495 100644
--- a/drivers/gpu/nova-core/gsp/fw.rs
+++ b/drivers/gpu/nova-core/gsp/fw.rs
@@ -242,9 +242,9 @@ struct WprMetaFields {
let fields = match fb_info {
GspFbInfo::Ranges(ranges) => WprMetaFields {
- gsp_fw_rsvd_start: ranges.heap.start,
- non_wpr_heap_offset: ranges.heap.start,
- non_wpr_heap_size: ranges.heap.len(),
+ gsp_fw_rsvd_start: ranges.non_wpr_heap.start,
+ non_wpr_heap_offset: ranges.non_wpr_heap.start,
+ non_wpr_heap_size: ranges.non_wpr_heap.len(),
gsp_fw_wpr_start: ranges.wpr2.start,
gsp_fw_heap_offset: ranges.wpr2_heap.start,
gsp_fw_heap_size: ranges.wpr2_heap.len(),
@@ -263,7 +263,7 @@ struct WprMetaFields {
pmu_reserved_size: ranges.pmu_reserved_size,
},
GspFbInfo::Sizes(sizes) => WprMetaFields {
- non_wpr_heap_size: sizes.heap_size,
+ non_wpr_heap_size: sizes.non_wpr_heap_size,
gsp_fw_heap_size: sizes.wpr2_heap_size,
frts_size: sizes.frts_size,
gsp_fw_heap_vf_partition_count: sizes.vf_partition_count,
--
2.54.0
next prev parent reply other threads:[~2026-07-03 10:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 10:22 [PATCH v2 00/10] gpu: nova-core: blackwell follow-ups and fixes Eliot Courtney
2026-07-03 10:22 ` [PATCH v2 01/10] gpu: nova-core: fsp: limit FSP receive message allocation size Eliot Courtney
2026-07-03 10:22 ` [PATCH v2 02/10] gpu: nova-core: fsp: catch bogus queue pointer issues Eliot Courtney
2026-07-03 10:22 ` [PATCH v2 03/10] gpu: nova-core: gsp: ensure lifetime for FMC boot DMA allocations Eliot Courtney
2026-07-03 10:22 ` [PATCH v2 04/10] gpu: nova-core: gsp: ensure LibOS DMA allocation lives long enough Eliot Courtney
2026-07-03 10:22 ` [PATCH v2 05/10] gpu: nova-core: split FbLayout into FSP and non-FSP versions Eliot Courtney
2026-07-03 10:22 ` [PATCH v2 06/10] gpu: nova-core: correct FRTS vidmem offset calculation Eliot Courtney
2026-07-03 10:22 ` Eliot Courtney [this message]
2026-07-03 10:22 ` [PATCH v2 08/10] gpu: nova-core: return non-WPR heap size as u64 from HALs Eliot Courtney
2026-07-03 10:22 ` [PATCH v2 09/10] gpu: nova-core: correct RISC-V HALTED field Eliot Courtney
2026-07-03 10:22 ` [PATCH v2 10/10] gpu: nova-core: wait for RISC-V HALTED on FSP unload Eliot Courtney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703-blackwell-fixes-v2-7-8e3d8bc32bb9@nvidia.com \
--to=ecourtney@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox