From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 256DA422536; Thu, 16 Jul 2026 13:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784206957; cv=none; b=aerh+LU2GkOYHVEgk3xCJtrv4btFdfBGPn5foMY1FFX+53xyC67zxhKz7JnDvJmzo5OyEtmITY16+i6B3d9YT64o2LIK3H7H63lFMcI2X8zZcA9+CJwi09iyTr1BmoyUxNKIt8sfVyV5dMYTDGAVV57DLjkUOKfrWrsZIG4dnmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784206957; c=relaxed/simple; bh=P9UPmJMz3AA6eRI9/OSTVoLVwNjsmQ+mX4uw+c/SZFA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IbmvBqwJrlo/6WblhWYCwa1eUZZpMYpXDSSOXnTcKy5hUuAStRYzVFGpxR5agQ7o+h+kc+0WRZncMvEQnbRqHDtuwj1LnlNajX7Zv2+AAaJSmJxmAKBvcVBuDLpAOOSTtlaZ9cHHKfN2wEreA9aIVUm0An//msB+XXSe2TqZabk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C850MqgX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C850MqgX" Received: by smtp.kernel.org (Postfix) with ESMTPS id C73AAC2BCF4; Thu, 16 Jul 2026 13:02:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1784206956; bh=P9UPmJMz3AA6eRI9/OSTVoLVwNjsmQ+mX4uw+c/SZFA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=C850MqgXIcaSeUtXGKp3itwQje5PijjZHrClLyHTR7r+0DmDcAFILXacrAhjJMZWV TGI+upzKbfYvs6sRyc/xldRR/yyB5pDPaMxpjK1V0o6DMfDezW32MnKSwnvdwEyMru /Nnm2qIgSEP7F4juMj1CsSuZVTK0V/ukaJ3ETLcXeNmWsqAv4pt2elyWbcjAFEhIA6 Zly3pEzKuqdFlD/0kXJsLj3SZncNpVBVA7iS3MZvLI+vxqZvnb7epI+d7jBdvFqykg oJYA0xS/emOpHsq00LTRpKSgjJHIF1gN6NB0r+eIF7JGVLkvACHrC2Dk7QM7BKhZP2 cGr4KogKplwwQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D18C44501; Thu, 16 Jul 2026 13:02:36 +0000 (UTC) From: Jahnavi MN via B4 Relay Date: Thu, 16 Jul 2026 13:02:34 +0000 Subject: [PATCH 1/3] rust_binder: Update defer_work bitmaps to use kernel::impl_flags! Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260716-b4-rust_binder_impl_flags-v1-1-b4201d3f15b3@google.com> References: <20260716-b4-rust_binder_impl_flags-v1-0-b4201d3f15b3@google.com> In-Reply-To: <20260716-b4-rust_binder_impl_flags-v1-0-b4201d3f15b3@google.com> To: Greg Kroah-Hartman , =?utf-8?q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Christian Brauner , Carlos Llamas , Alice Ryhl , Benno Lossin , Gary Guo Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Jahnavi MN X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784206955; l=3623; i=jahnavimn@google.com; s=20260702; h=from:subject:message-id; bh=/uxVIdRsjjzzayVpGS2ftrtM8UPE7MkaSdizzzP0eRo=; b=zbpP0nXpy6VPAfq11Yz/3KU5NwqiCk3ADs9Ti8zOM85dpUUFLvs5IuzYThnIbkXkcwoG5Q6Br 3Er+j6wOXlfB8L/tJcXLwmWlluf9eKBJDvO4YIj8lsOfnjIjCgNZADZ X-Developer-Key: i=jahnavimn@google.com; a=ed25519; pk=9aLfw3FepTOJwTS7jRXm7pDH87eBeZMXBPrqwU0//RE= X-Endpoint-Received: by B4 Relay for jahnavimn@google.com/20260702 with auth_id=849 X-Original-From: Jahnavi MN Reply-To: jahnavimn@google.com From: Jahnavi MN - Define `DeferWorks(u8)` and `DeferWork` enum using `bit_u8` offsets. - Change `ProcessInner.defer_work` type from `u8` to `DeferWorks`. - Update `Process::release()` and `Process::flush()` to check for empty states using `DeferWorks::empty()`. - Update the workqueue runner to inspect flags using `.contains()`. Signed-off-by: Jahnavi MN --- drivers/android/binder/process.rs | 34 ++++++++++++++++++++++------------ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs index 0555c4bd503e..84747d998636 100644 --- a/drivers/android/binder/process.rs +++ b/drivers/android/binder/process.rs @@ -16,6 +16,7 @@ use kernel::{ bindings, + bits::bit_u8, cred::Credential, error::Error, fs::file::{self, File}, @@ -70,9 +71,18 @@ fn new(address: usize, size: usize) -> Self { } } -// bitflags for defer_work. -const PROC_DEFER_FLUSH: u8 = 1; -const PROC_DEFER_RELEASE: u8 = 2; +kernel::impl_flags!( + /// Represents multiple deferred work flags. + #[derive(Debug, Clone, Default, Copy, PartialEq, Eq)] + pub struct DeferWorks(u8); + + /// Represents a single deferred work category. + #[derive(Debug, Clone, Copy, PartialEq, Eq)] + pub enum DeferWork { + Flush = bit_u8(0), + Release = bit_u8(1), + } +); #[derive(Copy, Clone)] pub(crate) enum IsFrozen { @@ -121,7 +131,7 @@ pub(crate) struct ProcessInner { started_thread_count: u32, /// Bitmap of deferred work to do. - defer_work: u8, + defer_work: DeferWorks, /// Number of transactions to be transmitted before processes in freeze_wait /// are woken up. @@ -151,7 +161,7 @@ fn new() -> Self { requested_thread_count: 0, max_threads: 0, started_thread_count: 0, - defer_work: 0, + defer_work: DeferWorks::default(), outstanding_txns: 0, is_frozen: IsFrozen::No, sync_recv: false, @@ -489,13 +499,13 @@ fn run(me: Arc) { { let mut inner = me.inner.lock(); defer = inner.defer_work; - inner.defer_work = 0; + inner.defer_work = DeferWorks::default(); } - if defer & PROC_DEFER_FLUSH != 0 { + if defer.contains(DeferWork::Flush) { me.deferred_flush(); } - if defer & PROC_DEFER_RELEASE != 0 { + if defer.contains(DeferWork::Release) { me.deferred_release(); } } @@ -1649,8 +1659,8 @@ pub(crate) fn release(this: Arc, _file: &File) { let should_schedule; { let mut inner = this.inner.lock(); - should_schedule = inner.defer_work == 0; - inner.defer_work |= PROC_DEFER_RELEASE; + should_schedule = inner.defer_work == DeferWorks::empty(); + inner.defer_work |= DeferWork::Release; binderfs_file = inner.binderfs_file.take(); } @@ -1667,8 +1677,8 @@ pub(crate) fn flush(this: ArcBorrow<'_, Process>) -> Result { let should_schedule; { let mut inner = this.inner.lock(); - should_schedule = inner.defer_work == 0; - inner.defer_work |= PROC_DEFER_FLUSH; + should_schedule = inner.defer_work == DeferWorks::empty(); + inner.defer_work |= DeferWork::Flush; } if should_schedule { -- 2.55.0.229.g6434b31f56-goog