From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Carlos Llamas" <cmllamas@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Matthew Maurer" <mmaurer@google.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/6] rust_binder: avoid allocating under node_refs for freeze listeners
Date: Fri, 17 Jul 2026 15:20:23 +0200 [thread overview]
Message-ID: <2026071755-covenant-shining-6910@gregkh> (raw)
In-Reply-To: <20260707-binder-noderefs-spin-v4-1-7c3c8bc16339@google.com>
On Tue, Jul 07, 2026 at 10:28:51AM +0000, Alice Ryhl wrote:
> The node_refs mutex needs to be changed to a spinlock, so in preparation
> for that, update freeze.rs to avoid allocating under the node_refs lock.
> This is done by adding a retry loop so that if add_freeze_listener()
> requires reallocating the KVVec<_> of freeze listeners, the caller will
> allocate a larger vector and retry.
>
> Analogously, the remove_freeze_listener() function is updated to return
> the empty KVVec<_> when it is no longer needed, to avoid calling
> kvfree() under the node_refs lock.
>
> Reviewed-by: Matthew Maurer <mmaurer@google.com>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> drivers/android/binder/freeze.rs | 65 +++++++++++++++++++++++++++-------------
> drivers/android/binder/node.rs | 41 +++++++++++++------------
> 2 files changed, 64 insertions(+), 42 deletions(-)
>
This doesn't apply against my tree now, given all of the binder patches
now added? Can you rebase against char-misc-testing and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2026-07-17 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 10:28 [PATCH v4 0/6] rust_binder: update Process::node_refs to use SpinLock Alice Ryhl
2026-07-07 10:28 ` [PATCH v4 1/6] rust_binder: avoid allocating under node_refs for freeze listeners Alice Ryhl
2026-07-17 13:20 ` Greg Kroah-Hartman [this message]
2026-07-17 13:48 ` Alice Ryhl
2026-07-17 14:35 ` Greg Kroah-Hartman
2026-07-07 10:28 ` [PATCH v4 2/6] rust_binder: avoid dropping NodeRef in update_ref() under lock Alice Ryhl
2026-07-07 10:28 ` [PATCH v4 3/6] rust_binder: schedule NodeDeath outside of node_refs lock Alice Ryhl
2026-07-07 10:28 ` [PATCH v4 4/6] rust_binder: keep NodeDeath in NodeRefInfo during process cleanup Alice Ryhl
2026-07-07 10:28 ` [PATCH v4 5/6] rust_binder: avoid destructors in insert_or_update_handle() Alice Ryhl
2026-07-07 10:28 ` [PATCH v4 6/6] rust_binder: update Process::node_refs to use SpinLock Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026071755-covenant-shining-6910@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=cmllamas@google.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mmaurer@google.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox