Rust for Linux List
 help / color / mirror / Atom feed
From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
To: Mark Brown <broonie@kernel.org>, Boqun Feng <boqun@kernel.org>,
	 Gary Guo <gary@garyguo.net>, Alice Ryhl <aliceryhl@google.com>,
	 Miguel Ojeda <ojeda@kernel.org>, Harry Yoo <harry@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Hao Li" <hao.li@linux.dev>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Bert Karwatzki" <spasswolf@web.de>,
	"Lyude Paul" <lyude@redhat.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	linux-next@vger.kernel.org,
	"Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Subject: [PATCH -next] rust: poll: fix compilation error due to kvfree_call_rcu changes
Date: Wed, 05 Aug 2026 18:28:45 +0200	[thread overview]
Message-ID: <20260805-slab-rust-fix-v1-1-c4d4c1b69de2@kernel.org> (raw)

kvfree_call_rcu() changed the type of its parameter to kvfree_rcu_head
in commit acc6fdade62c ("mm/slab: introduce struct kvfree_rcu_head for
kvfree_rcu batching") in the slab tree

Meanwhile rust started relying on the old type in commit e5e86df8b666
("rust: poll: use kfree_rcu() for PollCondVar") in the char-misc tree.

Reconcile the two changes as suggested by Gary [1]. This should be
applied as the merge commit for either slab tree or char-misc tree,
whichever is merged to -next later. The code it changes comes from
char-misc tree.

[1] https://lore.kernel.org/all/DKFF147BG8PR.I12RKSRFQS1B@garyguo.net/

Suggested-by: Gary Guo <gary@garyguo.net>
Closes: https://lore.kernel.org/all/20260731075644.20215-1-ojeda@kernel.org/
Closes: https://lore.kernel.org/all/20260731122826.737703-1-spasswolf@web.de/
Signed-off-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
---
 rust/kernel/sync/poll.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/sync/poll.rs b/rust/kernel/sync/poll.rs
index 684dfa242b1a..f3cdf95db12d 100644
--- a/rust/kernel/sync/poll.rs
+++ b/rust/kernel/sync/poll.rs
@@ -124,7 +124,7 @@ pub struct PollCondVarBox {
 struct PollCondVarBoxInner {
     #[pin]
     inner: PollCondVar,
-    rcu: Opaque<bindings::callback_head>,
+    rcu: Opaque<bindings::kvfree_rcu_head>,
 }
 
 // SAFETY: PollCondVar is Send

---
base-commit: 1701fda2f58e345c050f4309971bdc07cd6146ba
change-id: 20260805-slab-rust-fix-b1828ce329e3


             reply	other threads:[~2026-08-05 16:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05 16:28 Vlastimil Babka (SUSE) [this message]
2026-08-05 16:39 ` [PATCH -next] rust: poll: fix compilation error due to kvfree_call_rcu changes Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260805-slab-rust-fix-v1-1-c4d4c1b69de2@kernel.org \
    --to=vbabka@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=arnd@arndb.de \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hao.li@linux.dev \
    --cc=harry@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=nathan@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=spasswolf@web.de \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox