From: FUJITA Tomonori <tomo@flapping.org>
To: miguel.ojeda.sandonis@gmail.com
Cc: tomo@flapping.org, gary@garyguo.net, ojeda@kernel.org,
a.hindborg@kernel.org, acourbot@nvidia.com, aliceryhl@google.com,
anna-maria@linutronix.de, bjorn3_gh@protonmail.com,
boqun@kernel.org, dakr@kernel.org, daniel.almeida@collabora.com,
frederic@kernel.org, jstultz@google.com, lossin@kernel.org,
lyude@redhat.com, sboyd@kernel.org, tamird@kernel.org,
tglx@kernel.org, tmgross@umich.edu, work@onurozkan.dev,
rust-for-linux@vger.kernel.org, fujita.tomonori@gmail.com
Subject: Re: [PATCH v1 2/2] rust: time: add Delta::to_jiffies_timeout() for timeout conversion
Date: Wed, 12 Aug 2026 22:45:17 +0900 (JST) [thread overview]
Message-ID: <20260812.224517.198100381475206098.tomo@flapping.org> (raw)
In-Reply-To: <CANiq72kuOa-EKj7MHUwzjn4WiZ9f9mWJbuYsfe+PcrWgN2PgfQ@mail.gmail.com>
On Wed, 12 Aug 2026 08:06:10 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> On Wed, Aug 12, 2026 at 2:05 AM FUJITA Tomonori <tomo@flapping.org> wrote:
>>
>> Miguel, you suggested landing the minimum set, e.g. the first 2 or
>> first 4 patches. Patches 1-3 are already in, so that leaves patch
>> 4. Would you like to take this version, which clamps the result and
>> has a KUnit test that fails on arm with HZ=1000 without the clamp,
>> or should I hold it for early next cycle? Either is fine with me.
>
> Up to timekeeping, but it is very late and I think Andreas was already
> on the fence of deferring everything even before this version.
Make sense, let's defer this. I will prepare it for the next cycle.
> If we were to actually take it, then I think that, generally speaking,
> any version that works in all cases is to be strongly favored even if
> it can be optimized/improved later, i.e. what I think matters the most
> is agreeing on the documented contract, i.e. to agree on what we want
> the function to actually do. Function bodies can always be improved
> later.
Agreed.
prev parent reply other threads:[~2026-08-12 13:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 15:01 [PATCH v1 0/2] Add Delta::to_jiffies_timeout() with tests FUJITA Tomonori
2026-08-11 15:01 ` [PATCH v1 1/2] rust: time: add example and KUnit test for Delta::as_millis_ceil() FUJITA Tomonori
2026-08-11 15:01 ` [PATCH v1 2/2] rust: time: add Delta::to_jiffies_timeout() for timeout conversion FUJITA Tomonori
2026-08-11 16:44 ` Gary Guo
2026-08-12 0:05 ` FUJITA Tomonori
2026-08-12 6:06 ` Miguel Ojeda
2026-08-12 11:55 ` Gary Guo
2026-08-12 13:45 ` FUJITA Tomonori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812.224517.198100381475206098.tomo@flapping.org \
--to=tomo@flapping.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tamird@kernel.org \
--cc=tglx@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox