From: Rafael Passos <rafael@rcpassos.me>
To: rust-for-linux@vger.kernel.org, aliceryhl@google.com,
gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
Christian Brauner <brauner@kernel.org>,
cmllamas@google.com
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Brigham Campbell <me@brighamcampbell.com>,
Jori Koolstra <jkoolstra@xs4all.nl>,
Rafael Passos <rafael@rcpassos.me>
Subject: [PATCH v3] rust_binder: speed up get_node_debug_info using lower_bound iter
Date: Fri, 14 Aug 2026 18:50:57 -0300 [thread overview]
Message-ID: <20260814215145.2050599-1-rafael@rcpassos.me> (raw)
Finding the next node in the RBTree can be done more efficiently using
the cursor_lower_bound, as it reduces cost from O(n) to O(log n).
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Link: https://github.com/Rust-for-Linux/linux/issues/1249
Suggested-by: Alice Ryhl <aliceryhl@google.com>
Signed-off-by: Rafael Passos <rafael@rcpassos.me>
---
V1: https://lore.kernel.org/rust-for-linux/20260728012249.3084154-1-rafael@rcpassos.me/
Changes from V1:
- remove the "if/else" block checking if the current>prt.
The cursor_lower_bound function returns the "key" or the next larger.
This is indeed better, my check was unnecessary.
- add a comment about this fact before the cursor_lower_bound
V2: https://lore.kernel.org/rust-for-linux/20260731133253.661634-1-rafael@rcpassos.me/
Changes from V2:
- formatting fixes with rustfmt
drivers/android/binder/process.rs | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
index cdd1a9079726..b74c26f041bf 100644
--- a/drivers/android/binder/process.rs
+++ b/drivers/android/binder/process.rs
@@ -1174,11 +1174,10 @@ fn get_node_debug_info(&self, data: UserSlice) -> Result {
{
let inner = self.inner.lock();
- for (node_ptr, node) in &inner.nodes {
- if *node_ptr > ptr {
- node.populate_debug_info(&mut out, &inner);
- break;
- }
+ // cursor_lower_bound retrieves the "key" passed or the next existing larger key
+ if let Some(cursor) = inner.nodes.cursor_lower_bound(&(ptr + 1)) {
+ let (_, node) = cursor.current();
+ node.populate_debug_info(&mut out, &inner);
}
}
--
2.55.0
next reply other threads:[~2026-08-14 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 21:50 Rafael Passos [this message]
2026-09-03 13:40 ` [PATCH v3] rust_binder: speed up get_node_debug_info using lower_bound iter Rafael Passos
2026-09-04 8:12 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814215145.2050599-1-rafael@rcpassos.me \
--to=rafael@rcpassos.me \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jkoolstra@xs4all.nl \
--cc=me@brighamcampbell.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox