From: nenkov2004@gmail.com
To: rust-for-linux@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alice Ryhl <aliceryhl@google.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
linux-kernel@vger.kernel.org, ChrisX101010 <nenkov2004@gmail.com>
Subject: [PATCH] rust: binder: Use lower bound for node debug lookup
Date: Mon, 31 Aug 2026 07:26:35 +0200 [thread overview]
Message-ID: <20260831052635.42417-1-nenkov2004@gmail.com> (raw)
From: ChrisX101010 <nenkov2004@gmail.com>
The Binder node debug lookup currently walks the process node RBTree
from the beginning until it finds the first node pointer greater than
the requested pointer.
Use RBTree::cursor_lower_bound() to start the lookup at the relevant
tree position instead. When the lower-bound key is equal to the
requested pointer, inspect the next node to preserve the existing
strictly-greater-than semantics.
This changes the tree lookup from a linear scan to an O(log n) search
without changing the returned node semantics.
Suggested-by: Alice Ryhl <aliceryhl@google.com>
Link: https://github.com/Rust-for-Linux/linux/issues/1249
Signed-off-by: ChrisX101010 <nenkov2004@gmail.com>
---
drivers/android/binder/process.rs | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/android/binder/process.rs b/drivers/android/binder/process.rs
index 5372bfbd9..8e7218ee0 100644
--- a/drivers/android/binder/process.rs
+++ b/drivers/android/binder/process.rs
@@ -1208,10 +1208,14 @@ fn get_node_debug_info(&self, data: UserSlice) -> Result {
{
let inner = self.inner.lock();
- for (node_ptr, node) in &inner.nodes {
+
+ if let Some(cursor) = inner.nodes.cursor_lower_bound(&ptr) {
+ let (node_ptr, node) = cursor.current();
+
if *node_ptr > ptr {
node.populate_debug_info(&mut out, &inner);
- break;
+ } else if let Some((_, node)) = cursor.peek_next() {
+ node.populate_debug_info(&mut out, &inner);
}
}
}
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
--
2.43.0
next reply other threads:[~2026-08-31 5:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 5:26 nenkov2004 [this message]
2026-08-31 5:39 ` [PATCH] rust: binder: Use lower bound for node debug lookup Greg Kroah-Hartman
2026-08-31 5:49 ` [PATCH v2] " nenkov2004
2026-08-31 12:30 ` [PATCH] " Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831052635.42417-1-nenkov2004@gmail.com \
--to=nenkov2004@gmail.com \
--cc=aliceryhl@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox