From: Chunfeng Song <springbreeze@stu.pku.edu.cn>
To: FUJITA Tomonori <tomo@flapping.org>
Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
rust-for-linux@vger.kernel.org, andrew@lunn.ch,
hkallweit1@gmail.com, rmk+kernel@armlinux.org.uk,
ojeda@kernel.org, boqun@kernel.org, gary@garyguo.net,
fujita.tomonori@gmail.com, tmgross@umich.edu,
stable@vger.kernel.org
Subject: Re: [PATCH net v5] rust: net: phy: fix off-by-one bit positions in device status accessors
Date: Thu, 10 Sep 2026 05:45:42 +0000 [thread overview]
Message-ID: <20260910054542.163981-1-springbreeze@stu.pku.edu.cn> (raw)
In-Reply-To: <20260909.164909.180036819630013679.tomo@flapping.org>
Thanks for the review. You are right on all three points, and they are
addressed in v6:
- The commit message now names read_status() instead of the vague
"link-change handling".
- The masking claim is gone, and the impact is described correctly:
since ax88796b has its own driver, phy_attach_direct() leaves
is_genphy_driven at 0, so the broken is_autoneg_enabled() reads bit
13 as 0 and always returns false, and read_status() never reaches
the resolve_aneg_linkmode() call.
- The SAFETY comments now justify the raw accessor calls themselves:
the pointer is valid and there is no concurrent write to the field.
The v6 patch will be posted as a separate thread.
Cheers,
Chunfeng
prev parent reply other threads:[~2026-09-10 5:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 14:32 [PATCH net v5] rust: net: phy: fix off-by-one bit positions in device status accessors Chunfeng Song
2026-09-09 7:49 ` FUJITA Tomonori
2026-09-10 5:45 ` Chunfeng Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910054542.163981-1-springbreeze@stu.pku.edu.cn \
--to=springbreeze@stu.pku.edu.cn \
--cc=andrew@lunn.ch \
--cc=boqun@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rust-for-linux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=tomo@flapping.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).