Rust for Linux List
 help / color / mirror / Atom feed
From: FUJITA Tomonori <tomo@flapping.org>
To: a.hindborg@kernel.org
Cc: tomo@flapping.org, gary@garyguo.net, ojeda@kernel.org,
	acourbot@nvidia.com, aliceryhl@google.com,
	anna-maria@linutronix.de, bjorn3_gh@protonmail.com,
	boqun@kernel.org, dakr@kernel.org, daniel.almeida@collabora.com,
	frederic@kernel.org, jstultz@google.com, lossin@kernel.org,
	lyude@redhat.com, sboyd@kernel.org, tamird@kernel.org,
	tglx@kernel.org, tmgross@umich.edu, work@onurozkan.dev,
	rust-for-linux@vger.kernel.org, fujita.tomonori@gmail.com
Subject: Re: [PATCH v4 2/2] rust: time: add Delta::to_jiffies_timeout() for timeout conversion
Date: Fri, 25 Sep 2026 18:39:24 +0900 (JST)	[thread overview]
Message-ID: <20260925.183924.808421603238938986.tomo@flapping.org> (raw)
In-Reply-To: <87zex52224.fsf@t14s.mail-host-address-is-not-set>

On Fri, 25 Sep 2026 10:00:19 +0200
Andreas Hindborg <a.hindborg@kernel.org> wrote:

>> diff --git a/rust/kernel/Kconfig.test b/rust/kernel/Kconfig.test
>> index e6a5c7a795f0..0087749995d2 100644
>> --- a/rust/kernel/Kconfig.test
>> +++ b/rust/kernel/Kconfig.test
>> @@ -83,4 +83,14 @@ config RUST_BITFIELD_KUNIT_TEST
>>
>>  	  If unsure, say N.
>>
>> +config RUST_TIME_KUNIT_TEST
>> +	bool "KUnit tests for the Rust time API" if !KUNIT_ALL_TESTS
>> +	default KUNIT_ALL_TESTS
>> +	help
>> +	  This option enables KUnit tests for the Rust time API.
>> +	  These are only for development and testing, not for regular
>> +	  kernel use cases.
>> +
>> +	  If unsure, say N.
> 
> Why would you gate out the tests? They do not look like they take long
> to run or anything.

Documentation/rust/testing.rst says:

  Each test suite should be guarded by a Kconfig option in
  ``rust/kernel/Kconfig.test``.

I think that the reason is the kernel image size. From commit
e74b7a3f5aee ("rust: tests: add Kconfig for KUnit test"):

  All the tests are compiled unconditionally now, which adds ~200 kB to
  the kernel image for me on x86_64. As Rust matures, this bloating will
  inevitably grow.


  reply	other threads:[~2026-09-25  9:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 23:25 [PATCH v4 0/2] Add Delta::to_jiffies_timeout() FUJITA Tomonori
2026-09-24 23:25 ` [PATCH v4 1/2] rust: bindings: set HZ to CONFIG_HZ FUJITA Tomonori
2026-09-24 23:25 ` [PATCH v4 2/2] rust: time: add Delta::to_jiffies_timeout() for timeout conversion FUJITA Tomonori
2026-09-25  8:00   ` Andreas Hindborg
2026-09-25  9:39     ` FUJITA Tomonori [this message]
2026-09-25 14:48       ` Miguel Ojeda
2026-09-28  9:37         ` Andreas Hindborg
2026-09-28  9:45           ` Miguel Ojeda
2026-09-28  9:57             ` Andreas Hindborg
2026-09-29 10:15 ` [PATCH v4 0/2] Add Delta::to_jiffies_timeout() Andreas Hindborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925.183924.808421603238938986.tomo@flapping.org \
    --to=tomo@flapping.org \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=anna-maria@linutronix.de \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=frederic@kernel.org \
    --cc=fujita.tomonori@gmail.com \
    --cc=gary@garyguo.net \
    --cc=jstultz@google.com \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tamird@kernel.org \
    --cc=tglx@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox