From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 799C53BB9F7 for ; Thu, 8 Oct 2026 05:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791437881; cv=none; b=fZPV8ITKesbBeWThqjcZp3DOI8VsKPjaKLaLglwR7QDb+6eooxWbD/9s+jOiirZbOpKBcaDsbAMzQe3En4JBQ+cb2yAJH4JJDs4GqEQ8rY5b+qyHBkHyBGXP7Vun9afyIc5EPj6YwN8MZ0cqagLGAXFA8lY1nTSqBlbQ0dQsT3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791437881; c=relaxed/simple; bh=1Es+O5gUAfmFViPOKvPNBGlel3oVhwqYtDml3CwM+Lo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bYSeoqSntn59A/S0qrIJJY6KVxh/9EPuKsqM899Hu+j/aI2UXH9vPXeHDhdVemLrVB/g33kQltwioGzf2/Tj1mLVcDQGTkezX//pkBv63ZBWk5aZ6AUL2/aqvv7hlol5NzuzG3lK41VbSxnae3pNbzDtCw/CyIsRV9MP1s217jM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TWbGwVaF; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TWbGwVaF" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-48b0584ad71so1746479f8f.0 for ; Wed, 07 Oct 2026 22:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791437877; x=1792042677; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RrJHqVEE809VPtPoK85AUD6Bvdktoej0RW32RmBaNCM=; b=TWbGwVaFPJSrj/a/pKFkolXf/0mYoD4TfrinJZtcCDo1skxffrv3CMqUKVNnM+NQbi Wlcg05fNEcTa6GbvgSWq99EOJYmaVd7zNqMmnjoa2sB8W8iLcYTD+xRmgxBfY74PzrLp uM29jDsjwQKfTLRv019mIDURn7nSCKTbCKCuhN6mtjvv8GJOc1LJ3AUOS6kwOMDku33T mPAIOOsCLcxLHmOhzvTxsQatrb2bmL70JYQMgMpV7JcWdA1tciLkTM5TXwa7t+4thPBL l5xe9YhSZ7uf0IGkZT7vardjLeHYO4CLuvk1E/WnvTEF8dIzrQu3at7HFz98Z+aleSBg z44A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791437877; x=1792042677; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=RrJHqVEE809VPtPoK85AUD6Bvdktoej0RW32RmBaNCM=; b=Z4fzJg2ujlvZj3w1AVtQbgMS4S6thr6Iq2wmuNm3dQZ2ARMGaQV3QSUiI454LRs3VZ rAk71pRBQGgPkhv1NWE7wLT4p5E4uLrsVGCl499JTpIdHxOKKR/r1qb+ArXOSBc7KqkT DmABvZlpQtfn4KFQp28+5/zgywmA5/eCDRS5bJwqJjzNhjNfnNMNEvp6CvfhcGnZmcJN pUMV2Bh1az8Cicos0sCfd2lsuW49HAg1NGkCigRe6Vsp5FXDhZLXzeK0QgOFM6j4qPSE Ov2Rk3eic+L+yV0G/GDMiQArfF0bjNgtrQdCu3+HX1pfjCYt0vwGauaiQ8tvdT+ln1se QbDg== X-Forwarded-Encrypted: i=1; AKwUvByX+9iX8cSKKBu3Hj4wzrfCbIHSFySOLAmK42fJIfmmP/AKLXmyb9nFnJJqcN8vEKpAbyPBuJCJiOGQwFiw7w==@vger.kernel.org X-Gm-Message-State: AFq9FYIU+Kg3vXVOog0/F7YfbBVBCpTCSydZtylHp5E3b4OoRioCM02a gVmutQyLTxObIoLQGXnZXuLW4wW1hQjV6m8eIVNtP6oJ6Qix3fC4y5NC X-Gm-Gg: AYBFou2YX5SOURa0C2clP3JT5TlHJn0yOWotVk++X+GHjyremC7VMezYC/9PfppdNLG wXU24thIlaZd2IL8I/ejQTN+s7VQR3S/82+tzbw+FlARqEpHzkuX+xH3qn6jeDmJqUZ50LAJVrB BAmaN4UmuIav3Ysl6PyasDvKPM8yKXxdp+Yei1mXSN/Fwamqi2MHZOgynPsfCwmdaDAtNbgg6hu fe6UcM5gmzgwPxRHKgYE9otb+/oOtRfr346M9UwKRWBEMbkyvRJ7xU4IzBIMXMv22FKLwxINhkn F01fTNmCM9L+WCjYr0Q6vpNfmz6AkFyptyoHilfI3pkry88JRROcag95pzXcMry0M6Ew/uHpiX/ sCJnYdBGtAm5y4sOEFA8GTjWdhRTjvXOBhk6pe8S5aG4YfmyjJJ4lkCJiqNlOR1X5Xu5auLvet5 /Ywvi25BoeJiWO17mDMv45NCcwrk3mzM1IlUomONNS4bIPFze1qrf64062o8CEhWsm30WDz9xUv Igq6I/q4wd7IYukquUcEN8SXVSwe86gAwADldsXjClMT37CPIQlGI6dxyxMSGhpys7q27qB3noH 5bfjoikp+Q9/5CVuyGzaEnUYEa9DBius8IAN6xJa5dsJLL1eqiOp+1O+x7b7xbbQ7F72seWL7fh nGo87KeE= X-Received: by 2002:a05:6000:2281:b0:488:89c7:31aa with SMTP id ffacd0b85a97d-48c728852dfmr8353187f8f.39.1791437876591; Wed, 07 Oct 2026 22:37:56 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-ad61-5a01-743c-891f-b33c-cae7.310.pool.telefonica.de. [2a02:3100:ad61:5a01:743c:891f:b33c:cae7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48c71d1f8fbsm8458219f8f.33.2026.10.07.22.37.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 07 Oct 2026 22:37:55 -0700 (PDT) From: Karl Mehltretter To: Russell King , Miguel Ojeda Cc: Karl Mehltretter , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?UTF-8?q?Onur=20=C3=96zkan?= , Arnd Bergmann , Linus Walleij , Christian Schrefl , Bradley Morgan , "Paul E . McKenney" , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-arm-kernel@lists.infradead.org, rust-for-linux@vger.kernel.org, llvm@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/6] ARM: cmpxchg: always inline __arch_xchg() and __cmpxchg() Date: Thu, 8 Oct 2026 07:37:41 +0200 Message-Id: <20261008053746.49631-2-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20261008053746.49631-1-kmehltretter@gmail.com> References: <20261008053746.49631-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __arch_xchg(), __cmpxchg() and __cmpxchg_local() end in a default case that calls an undefined function. That turns an unsupported size into a link error. It relies on the functions being inlined, so that the compiler can drop the default case for a constant size. They are only marked inline. gcc 8.1.0 with CC_OPTIMIZE_FOR_SIZE does not inline them in rust/helpers/helpers.c, which calls xchg() and cmpxchg() from many small helpers. The out-of-line copies keep the default case and the link fails. helpers.c:(.text+0x424): undefined reference to `__bad_xchg' helpers.c:(.text+0x4ac): undefined reference to `__bad_cmpxchg' Seen with bcm2835_defconfig and CONFIG_RUST=y on v7.3-rc1. The same config links with CONFIG_RUST=n. It also links with gcc 15.2.0 and with clang. v6.19 links. Commit ab717dd98bee ("rust: helpers: Add i8/i16 atomic xchg_acquire helpers") in v7.0 triggers __bad_xchg. Commit ac8f06ade38a ("rust: sync: atomic: Add Atomic<*{mut,const} T> support") in v7.1 also triggers __bad_cmpxchg. Mark the functions __always_inline. Fixes: ab717dd98bee ("rust: helpers: Add i8/i16 atomic xchg_acquire helpers") Fixes: ac8f06ade38a ("rust: sync: atomic: Add Atomic<*{mut,const} T> support") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Karl Mehltretter --- arch/arm/include/asm/cmpxchg.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/include/asm/cmpxchg.h b/arch/arm/include/asm/cmpxchg.h index 9beb64d30586..0ce5225af442 100644 --- a/arch/arm/include/asm/cmpxchg.h +++ b/arch/arm/include/asm/cmpxchg.h @@ -26,7 +26,7 @@ #define swp_is_buggy #endif -static inline unsigned long +static __always_inline unsigned long __arch_xchg(unsigned long x, volatile void *ptr, int size) { extern void __bad_xchg(volatile void *, int); @@ -155,8 +155,8 @@ extern void __bad_cmpxchg(volatile void *ptr, int size); * cmpxchg only support 32-bits operands on ARMv6. */ -static inline unsigned long __cmpxchg(volatile void *ptr, unsigned long old, - unsigned long new, int size) +static __always_inline unsigned long +__cmpxchg(volatile void *ptr, unsigned long old, unsigned long new, int size) { unsigned long oldval, res; @@ -220,9 +220,9 @@ static inline unsigned long __cmpxchg(volatile void *ptr, unsigned long old, sizeof(*(ptr))); \ }) -static inline unsigned long __cmpxchg_local(volatile void *ptr, - unsigned long old, - unsigned long new, int size) +static __always_inline unsigned long +__cmpxchg_local(volatile void *ptr, unsigned long old, unsigned long new, + int size) { unsigned long ret; -- 2.39.5 (Apple Git-154)