From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794828386; b=mA5M9ctytZdpAKwilnonD3ZqL8dksqOC+E9ce7hcCqp2qLkLL/9tp06E/5A9SFPmtu8T GfzoSs2/4djRkf4F2+b2NdwTh+UJIsRGMdsesBQNRuLr/L88jRWgY6d7gO3FQ0CXEOb5c BDN7r6s1F6rS4UJdLb6HBfq3ETqMbtfM7hU33BS86bQnxL19ywi8eipBlr7sL5n8Ahs+A jbsprmoNvyQpTZcoorWtIVXxj7mFjEaR9qtPSSQ8jztqMw8hrswLJNGTfTM9kx+95ILln YfAF7VR+I94eyJt8Gvs9vSSnVp3dg9p6fZI3SyZMgPORowRrsEJMzp9LGTw0NK3CdsQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794828386; h=DMARC-Filter:Received:Received:DKIM-Signature:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=Wyefxa4+TSlF7paSardcp8WRUJVTac2CKSbIHJILBvM=; b=HoZxs51VBY83gLuhwpBKyrTbIhN5MmQ8/q26VkPlJTltRuXBR72m1wB+u+BQcIsNCWOU Jh7I1WdJPbqt1KCecghW1keuUL+KcboTO8/5M7qZceDLf8Yw10toqd+XWWYTtXuSjIsQm s7GYiF59+Ur1W52VcebDCpoF40XDKqMfRnKyGk3tURaeEkVOSAlKeJqwAkD3p3w3lr9nl zew1MdwDB2UuScCIBIJ1y7CAe3sh0MNbcjDMAJldb/Rwt92yplBckMxhQOg87MEg5WZok wWL36QWk0/odZDMZsc2Gje5X4upb1kx3Pb+NlpBtTw+kb7vRBSqajSc26ZTyN0gOpMw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=JSw1Yqns; arc=none smtp.remote-ip=217.140.110.172 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D6B7D606A7A3; Mon, 16 Nov 2026 11:26:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D6B7D606A7A3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=JSw1Yqns Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3AC2D1A25; Mon, 16 Nov 2026 03:26:22 -0800 (PST) Received: from e120398-lin.trondheim.arm.com (e120398-lin.trondheim.arm.com [10.42.46.160]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D06AE3F632; Mon, 16 Nov 2026 03:26:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1794828385; bh=wBxz/8n5MK3qDyvxqWMMzlq8uuej1c5mv+pdu52hbHc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JSw1Yqnsgq0WMqFlUnuSGWFAKINKzEYExy+nL0w54O0x5a8jodK1KKvcuTczIGe3Y SuMSg/pfSiMilOlTj8ocmFKviDXFeHThZgH4tLcRk+EDCREomd1xw/VK+boircm/vV l3NHcnSZb9tKBFxvyNKpgQg7CEtR9mG5liMz64Gs= From: Ketil Johnsen To: Boris Brezillon , Steven Price , Liviu Dudau , Akash Goel , Karunika Choo , Lukas Zapolskas , Chris Diamand , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Almeida , Alice Ryhl Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Ketil Johnsen Subject: [PATCH v5 01/13] drm/panthor: De-duplicate FW memory section sync Date: Mon, 16 Nov 2026 12:25:49 +0100 Message-ID: <20261116112601.3483649-2-ketil.johnsen@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261116112601.3483649-1-ketil.johnsen@arm.com> References: <20261116112601.3483649-1-ketil.johnsen@arm.com> X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Handle the sync to device of FW memory sections inside panthor_fw_init_section_mem() so that the callers do not have to. This small improvement is also critical for protected FW sections, so we avoid issuing memory transactions to protected memory from CPU running in normal mode. Reviewed-by: Boris Brezillon Reviewed-by: Liviu Dudau Reviewed-by: Steven Price Signed-off-by: Ketil Johnsen --- drivers/gpu/drm/panthor/panthor_fw.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c index 4f1fab66a13bf..5f9f7a92c56a8 100644 --- a/drivers/gpu/drm/panthor/panthor_fw.c +++ b/drivers/gpu/drm/panthor/panthor_fw.c @@ -449,6 +449,7 @@ static void panthor_fw_init_section_mem(struct panthor_device *ptdev, struct panthor_fw_section *section) { bool was_mapped = !!section->mem->kmap; + struct sg_table *sgt; int ret; if (!section->data.size && @@ -467,6 +468,12 @@ static void panthor_fw_init_section_mem(struct panthor_device *ptdev, if (!was_mapped) panthor_kernel_bo_vunmap(section->mem); + + /* An sgt should have been requested when the kernel BO was GPU-mapped. */ + sgt = to_panthor_bo(section->mem->obj)->dmap.sgt; + if (!drm_WARN_ON_ONCE(&ptdev->base, !sgt)) + dma_sync_sgtable_for_device(ptdev->base.dev, sgt, + DMA_TO_DEVICE); } /** @@ -639,7 +646,6 @@ static int panthor_fw_load_section_entry(struct panthor_device *ptdev, if (section_size) { u32 cache_mode = hdr.flags & CSF_FW_BINARY_IFACE_ENTRY_CACHE_MODE_MASK; - struct panthor_gem_object *bo; u32 vm_map_flags = 0; u64 va = hdr.va.start; @@ -676,14 +682,6 @@ static int panthor_fw_load_section_entry(struct panthor_device *ptdev, } panthor_fw_init_section_mem(ptdev, section); - - bo = to_panthor_bo(section->mem->obj); - - /* An sgt should have been requested when the kernel BO was GPU-mapped. */ - if (drm_WARN_ON_ONCE(&ptdev->base, !bo->dmap.sgt)) - return -EINVAL; - - dma_sync_sgtable_for_device(ptdev->base.dev, bo->dmap.sgt, DMA_TO_DEVICE); } if (hdr.va.start == CSF_MCU_SHARED_REGION_START) @@ -738,17 +736,10 @@ panthor_reload_fw_sections(struct panthor_device *ptdev, bool full_reload) struct panthor_fw_section *section; list_for_each_entry(section, &ptdev->fw->sections, node) { - struct sg_table *sgt; - if (!full_reload && !(section->flags & CSF_FW_BINARY_IFACE_ENTRY_WR)) continue; panthor_fw_init_section_mem(ptdev, section); - - /* An sgt should have been requested when the kernel BO was GPU-mapped. */ - sgt = to_panthor_bo(section->mem->obj)->dmap.sgt; - if (!drm_WARN_ON_ONCE(&ptdev->base, !sgt)) - dma_sync_sgtable_for_device(ptdev->base.dev, sgt, DMA_TO_DEVICE); } } -- 2.43.0