Rust for Linux List
 help / color / mirror / Atom feed
From: Miguel Ojeda <ojeda@kernel.org>
To: gregkh@linuxfoundation.org
Cc: axboe@kernel.dk, hch@lst.de, patches@lists.linux.dev,
	sashal@kernel.org, stable@vger.kernel.org,
	Andreas Hindborg <a.hindborg@kernel.org>,
	Boqun Feng <boqun@kernel.org>,
	linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 6.12 0534/1756] block: remove BLK_MQ_F_SHOULD_MERGE
Date: Thu, 19 Nov 2026 15:08:30 +0100	[thread overview]
Message-ID: <20261119140830.15616-1-ojeda@kernel.org> (raw)
In-Reply-To: <20261118150030.389817521@linuxfoundation.org>

On Wed, 18 Nov 2026 15:44:21 +0100 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> BLK_MQ_F_SHOULD_MERGE is set for all tag_sets except those that purely
> process passthrough commands (bsg-lib, ufs tmf, various nvme admin
> queues) and thus don't even check the flag.  Remove it to simplify the
> driver interface.

>  enum {
> -	BLK_MQ_F_SHOULD_MERGE	= 1 << 0,
>  	BLK_MQ_F_TAG_QUEUE_SHARED = 1 << 1,

This causes:

    error[E0425]: cannot find value `BLK_MQ_F_SHOULD_MERGE` in crate `bindings`
      --> rust/kernel/block/mq/tag_set.rs:55:38
       |
    55 |                     flags: bindings::BLK_MQ_F_SHOULD_MERGE,
       |                                      ^^^^^^^^^^^^^^^^^^^^^ not found in `bindings`

We need:

  31d813a3b8cb ("rust: block: fix use of BLK_MQ_F_SHOULD_MERGE")

Cc: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Sasha Levin <sashal@kernel.org>
Cc: Andreas Hindborg <a.hindborg@kernel.org>
Cc: Boqun Feng <boqun@kernel.org>
Cc: linux-block@vger.kernel.org
Cc: rust-for-linux@vger.kernel.org

I hope that helps!

Cheers,
Miguel

           reply	other threads:[~2026-11-19 14:08 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20261118150030.389817521@linuxfoundation.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119140830.15616-1-ojeda@kernel.org \
    --to=ojeda@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=boqun@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox