rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Hui Zhu" <hui.zhu@linux.dev>
To: "Alice Ryhl" <aliceryhl@google.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
	"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
	"Vlastimil Babka" <vbabka@suse.cz>,
	"Liam R . Howlett" <Liam.Howlett@oracle.com>,
	"Uladzislau Rezki" <urezki@gmail.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	bjorn3_gh@protonmail.com, "Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, vitaly.wool@konsulko.se,
	"Hui Zhu" <zhuhui@kylinos.cn>,
	"Geliang Tang" <geliang@kernel.org>
Subject: Re: [PATCH v6 2/2] rust: alloc: kvec: add doc example for as_slice method
Date: Thu, 31 Jul 2025 02:53:13 +0000	[thread overview]
Message-ID: <21002139ec43d04f9fc6f58ce9250c7e8a4998e4@linux.dev> (raw)
In-Reply-To: <aInRtC5CRxyDTy5B@google.com>

2025年7月30日 16:03, "Alice Ryhl" <aliceryhl@google.com mailto:aliceryhl@google.com?to=%22Alice%20Ryhl%22%20%3Caliceryhl%40google.com%3E > 写到:


> 
> On Wed, Jul 30, 2025 at 11:35:22AM +0800, Hui Zhu wrote:
> 
> > 
> > From: Hui Zhu <zhuhui@kylinos.cn>
> >  
> >  Add a practical usage example to the documentation of KVec::as_slice()
> >  showing how to:
> >  Create a new KVec.
> >  Push elements into it.
> >  Convert to a slice via as_slice().
> >  
> >  Co-developed-by: Geliang Tang <geliang@kernel.org>
> >  Signed-off-by: Geliang Tang <geliang@kernel.org>
> >  Signed-off-by: Hui Zhu <zhuhui@kylinos.cn>
> > 
> It looks like this did not change since v5 where I gave my
> 
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> 
> tag. Please make sure to include the tag in future versions if you have
> not made any changes.

Oops!
Sorry for that.  Fixed in the v7 version.

Best,
Hui

> 
> Alice
>

  reply	other threads:[~2025-07-31  2:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30  3:35 [PATCH v6 0/2] rust: alloc: kvec doc example and allocator unit tests Hui Zhu
2025-07-30  3:35 ` [PATCH v6 1/2] rust: allocator: add KUnit tests for alignment guarantees Hui Zhu
2025-07-30  8:02   ` Alice Ryhl
2025-07-30  8:26   ` Kunwu Chan
2025-07-30  9:16   ` Miguel Ojeda
2025-07-31  2:54     ` Hui Zhu
2025-07-30  3:35 ` [PATCH v6 2/2] rust: alloc: kvec: add doc example for as_slice method Hui Zhu
2025-07-30  8:03   ` Alice Ryhl
2025-07-31  2:53     ` Hui Zhu [this message]
2025-07-30  8:27   ` Kunwu Chan
2025-07-30  8:31   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21002139ec43d04f9fc6f58ce9250c7e8a4998e4@linux.dev \
    --to=hui.zhu@linux.dev \
    --cc=Liam.Howlett@oracle.com \
    --cc=a.hindborg@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=geliang@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=urezki@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=vitaly.wool@konsulko.se \
    --cc=zhuhui@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).