From: Andrew Lunn <andrew@lunn.ch>
To: Jamie Cunliffe <Jamie.Cunliffe@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
steve.capper@arm.com, Asahi Lina <lina@asahilina.net>,
boqun.feng@gmail.com
Subject: Re: [PATCH v3 1/1] arm64: rust: Enable Rust support for AArch64
Date: Mon, 16 Oct 2023 23:47:48 +0200 [thread overview]
Message-ID: <210bae78-4f68-4bb3-9ebb-f3d9d07eb9fd@lunn.ch> (raw)
In-Reply-To: <20231016131523.1521965-2-Jamie.Cunliffe@arm.com>
> --- a/arch/x86/Makefile
> +++ b/arch/x86/Makefile
> @@ -68,6 +68,7 @@ export BITS
> # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53383
> #
> KBUILD_CFLAGS += -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx
> +KBUILD_RUSTFLAGS += --target=$(objtree)/scripts/target.json
It seems odd that adding arm64 support requires adding to the x86
Makefile.
Should this be moved into a patch of its own explaining why it is
needed? Do the refactoring first, then add support for a new
architecture?
Andrew
next prev parent reply other threads:[~2023-10-16 21:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 13:15 [PATCH v3 0/1] Rust enablement for AArch64 Jamie Cunliffe
2023-10-16 13:15 ` [PATCH v3 1/1] arm64: rust: Enable Rust support " Jamie Cunliffe
2023-10-16 18:14 ` Boqun Feng
2023-10-16 21:47 ` Andrew Lunn [this message]
2023-10-17 9:24 ` Miguel Ojeda
2023-10-17 9:27 ` Miguel Ojeda
2023-10-17 15:38 ` Miguel Ojeda
2023-10-17 17:47 ` Miguel Ojeda
2023-10-19 14:41 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=210bae78-4f68-4bb3-9ebb-f3d9d07eb9fd@lunn.ch \
--to=andrew@lunn.ch \
--cc=Jamie.Cunliffe@arm.com \
--cc=boqun.feng@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=lina@asahilina.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=steve.capper@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).