From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53FFD79B6B; Wed, 28 Feb 2024 17:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709143179; cv=none; b=ukG50MLY/+BEO27b6VaM7vu07ose5EeFR6b47pzKCUMwHEO09ftKIUXEEMKwfeHtFGF/fI6ZhGF0TVYkJ1xRhQAY2MM+CfO341XsNvWhD2cwC4+WgTUrKHc7CESMjRBwbdcqFRlF2+f+ucjTJ5TSEid0Mel7gvuU9xkd1vdM5Ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709143179; c=relaxed/simple; bh=BtdiY7GCH4yy8PvIrl7nW0rMOW2H+SjTJyaN3RxoRoo=; h=From:In-Reply-To:Content-Type:References:Date:Cc:To:MIME-Version: Message-ID:Subject; b=SEuRaAFBglBZSdfBePP7uvC7h+TkzE/v4zAYwHIMVZ/Brro9NdDfzZBvhpgkvWpyhMBPiQOGaTnaLsZUeoH8RimlaayZzHXXeJqFp89Yf+LxXYPtutPOM5syJXN+3kmMW13dZUCCtEWm1Cxw2OE0i6c+shKvIWVUaUVfx8lwuBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Received: from harlem.collaboradmins.com (harlem.collaboradmins.com [IPv6:2a01:4f8:1c0c:5936::1]) by madrid.collaboradmins.com (Postfix) with ESMTP id B488237820DA; Wed, 28 Feb 2024 17:59:35 +0000 (UTC) From: "Daniel Almeida" In-Reply-To: Content-Type: text/plain; charset="utf-8" X-Forward: 127.0.0.1 References: <20240227215146.46487-1-daniel.almeida@collabora.com> <20240227215146.46487-2-daniel.almeida@collabora.com> Date: Wed, 28 Feb 2024 17:59:35 +0000 Cc: wedsonaf@gmail.com, ojeda@kernel.org, mchehab@kernel.org, hverkuil@xs4all.nl, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, kernel@collabora.com To: "Alice Ryhl" Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <28f4-65df7480-b-5f6f8180@243208659> Subject: =?utf-8?q?Re=3A?= [RFC PATCH 1/1] =?utf-8?q?v4l2-core=3A?= rewrite the VP9 library in Rust User-Agent: SOGoMail 5.10.0 Content-Transfer-Encoding: quoted-printable Hi Alice! On Wednesday, February 28, 2024 11:13 -03, Alice Ryhl wrote: > I recommend taking an `*mut u8` here instead of `&mut u8` if you're > going to use `slice::from=5Fraw=5Fparts=5Fmut`. Or, if cbindgen allow= s it, > take an `&mut [u8; 8]` instead and eliminate the unsafe block. You're right, the signature here can change to `&mut [u8; 8]` instead. = This means no unsafe blocks at all. Thanks for the tip, -- Daniel