From: Benno Lossin <benno.lossin@proton.me>
To: Lyude Paul <lyude@redhat.com>, rust-for-linux@vger.kernel.org
Cc: "Danilo Krummrich" <dakr@redhat.com>,
airlied@redhat.com, "Ingo Molnar" <mingo@redhat.com>,
"Will Deacon" <will@kernel.org>,
"Waiman Long" <longman@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
"Valentin Obst" <kernel@valentinobst.de>
Subject: Re: [PATCH v5 3/3] rust: sync: Add SpinLockIrq
Date: Fri, 13 Sep 2024 14:15:45 +0000 [thread overview]
Message-ID: <30da83b3-5be0-431b-b57c-c9d371747e7d@proton.me> (raw)
In-Reply-To: <20240912190540.53221-4-lyude@redhat.com>
On 12.09.24 21:04, Lyude Paul wrote:
> A variant of SpinLock that is expected to be used in noirq contexts, and
> thus requires that the user provide an kernel::irq::IrqDisabled to prove
> they are in such a context upon lock acquisition. This is the rust
> equivalent of spin_lock_irqsave()/spin_lock_irqrestore().
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
>
> ---
>
> V2:
> * s/IrqSpinLock/SpinLockIrq/
> * Implement `lock::Backend` now that we have `Context`
> * Add missing periods
> * Make sure rustdoc examples compile correctly
> * Add documentation suggestions
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> ---
> rust/kernel/sync.rs | 2 +-
> rust/kernel/sync/lock/spinlock.rs | 104 ++++++++++++++++++++++++++++++
> 2 files changed, 105 insertions(+), 1 deletion(-)
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
---
Cheers,
Benno
next prev parent reply other threads:[~2024-09-13 14:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 19:04 [PATCH v5 0/3] rust: Add irq abstraction, SpinLockIrq Lyude Paul
2024-09-12 19:04 ` [PATCH v5 1/3] rust: Introduce irq module Lyude Paul
2024-09-13 13:33 ` Benno Lossin
2024-09-13 15:48 ` Daniel Almeida
2024-09-14 16:13 ` Gary Guo
2024-09-12 19:04 ` [PATCH v5 2/3] rust: sync: Introduce lock::Backend::Context Lyude Paul
2024-09-13 14:14 ` Benno Lossin
2024-09-13 15:49 ` Daniel Almeida
2024-09-12 19:04 ` [PATCH v5 3/3] rust: sync: Add SpinLockIrq Lyude Paul
2024-09-13 14:15 ` Benno Lossin [this message]
2024-09-13 15:49 ` Daniel Almeida
2024-09-13 15:49 ` [PATCH v5 0/3] rust: Add irq abstraction, SpinLockIrq Daniel Almeida
2024-09-14 16:18 ` Gary Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30da83b3-5be0-431b-b57c-c9d371747e7d@proton.me \
--to=benno.lossin@proton.me \
--cc=a.hindborg@samsung.com \
--cc=airlied@redhat.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@redhat.com \
--cc=gary@garyguo.net \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=lyude@redhat.com \
--cc=mingo@redhat.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
--cc=wedsonaf@gmail.com \
--cc=will@kernel.org \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).