From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B44CDF78 for ; Fri, 13 Sep 2024 14:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.22 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726236955; cv=none; b=MwKO7uOXBDAUgXc2e3idmGFeGpQMnQsrd/OeNXOIdHJB7LsTkFTW/ELwUC1PLOxfviuGmbNpFGbUYuKLf8+NKGoplAKpH1EX2rqIc90+5efQnTuNikv+KBLv2l6XJim6kCttMLyNotKv2gTJyOrGl4E9bNz6TPws6cs153oR1io= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726236955; c=relaxed/simple; bh=XPN8oqe/Nd2VGNTD5lsFfcllQTrbIOku5dzm8/IrMoo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m0S9SihmeiAYRvvUcEHZVxDKHFQb1luGgRUq3wOd3djEahoPWU35D5/GO8SdJ1TaxXGGTRbV3ABy3S2343KB0SH3OL3z69OmFUAVVNGQfg4QEakwW1ptDfudYYmAilDrK0+9Viz5V+YaTd7MlM+oVMxFH9XXbFZYCh75LbQCGIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=H70LYXQU; arc=none smtp.client-ip=185.70.43.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b="H70LYXQU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1726236951; x=1726496151; bh=pgg37Csd/pbMYJpE4NPiNE3WqHfYEli7aN12vFgrzHU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=H70LYXQUqs62wFgmwOmk5FP6y9NruiCPCTQjz2+rCR0Vt3aUyjuNikg1JuoaZgm/p C3nVI0JRcukF98ge0kOr4bnrN6KffnH2hIkb19/rLZlRTgh00B5nGxOe82VqLj0rt7 DlF587ViZRMjeoewnWuRUkBogH0kq3SX1lIYW9QHa0rdDOvGw/+2W2tANPVQv5UcLq zlije3UGkiNHjvMqvAgX6wUT5l1WkJ4a7lI2C58zTe68oAyceV8mGOGzOqEtWyNGRG ikGVNnetno0JBYAnjXreM65Z0SwIfPub3lgh5Ch2WIkTU+3ZX9URfIyIs1sHJJqHSE Em5s0D2Gibo6w== Date: Fri, 13 Sep 2024 14:15:45 +0000 To: Lyude Paul , rust-for-linux@vger.kernel.org From: Benno Lossin Cc: Danilo Krummrich , airlied@redhat.com, Ingo Molnar , Will Deacon , Waiman Long , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Martin Rodriguez Reboredo , Valentin Obst Subject: Re: [PATCH v5 3/3] rust: sync: Add SpinLockIrq Message-ID: <30da83b3-5be0-431b-b57c-c9d371747e7d@proton.me> In-Reply-To: <20240912190540.53221-4-lyude@redhat.com> References: <20240912190540.53221-1-lyude@redhat.com> <20240912190540.53221-4-lyude@redhat.com> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 1391b8127f473441273a0e6410657bbe61568de2 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12.09.24 21:04, Lyude Paul wrote: > A variant of SpinLock that is expected to be used in noirq contexts, and > thus requires that the user provide an kernel::irq::IrqDisabled to prove > they are in such a context upon lock acquisition. This is the rust > equivalent of spin_lock_irqsave()/spin_lock_irqrestore(). >=20 > Signed-off-by: Lyude Paul >=20 > --- >=20 > V2: > * s/IrqSpinLock/SpinLockIrq/ > * Implement `lock::Backend` now that we have `Context` > * Add missing periods > * Make sure rustdoc examples compile correctly > * Add documentation suggestions >=20 > Signed-off-by: Lyude Paul > --- > rust/kernel/sync.rs | 2 +- > rust/kernel/sync/lock/spinlock.rs | 104 ++++++++++++++++++++++++++++++ > 2 files changed, 105 insertions(+), 1 deletion(-) Reviewed-by: Benno Lossin --- Cheers, Benno