From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Markus Probst" <markus.probst@posteo.de>,
"Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: Add synology,microp device
Date: Mon, 9 Mar 2026 08:17:28 +0100 [thread overview]
Message-ID: <33efd44c-be12-468c-9505-ff0d7b66b701@kernel.org> (raw)
In-Reply-To: <20260308-synology_microp_initial-v2-1-9389963f31c5@posteo.de>
On 08/03/2026 19:41, Markus Probst wrote:
> Add the Synology Microp devicetree bindings. Those devices are
> microcontrollers found on Synology NAS devices. They are connected to a
> serial port on the host device.
>
> Those devices are used to control certain LEDs, fan speeds, a beeper, to
> handle buttons, fan failures and to properly shutdown and reboot the
> device.
>
> Signed-off-by: Markus Probst <markus.probst@posteo.de>
> ---
> .../devicetree/bindings/mfd/synology,microp.yaml | 49 ++++++++++++++++++++++
This is not an "MFD" device.
...
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/leds/common.h>
> +
> + mcu {
Please read previous comments.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-09 7:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 18:41 [PATCH v2 0/2] Introduce Synology Microp driver Markus Probst
2026-03-08 18:41 ` [PATCH v2 1/2] dt-bindings: mfd: Add synology,microp device Markus Probst
2026-03-09 7:17 ` Krzysztof Kozlowski [this message]
2026-03-08 18:41 ` [PATCH v2 2/2] mfd: Add initial synology microp driver Markus Probst
2026-03-08 18:55 ` Greg Kroah-Hartman
2026-03-08 19:15 ` Markus Probst
2026-03-09 5:56 ` Greg Kroah-Hartman
2026-03-09 9:43 ` Lee Jones
2026-03-09 12:52 ` Markus Probst
2026-03-09 13:07 ` Greg Kroah-Hartman
2026-03-09 13:34 ` Markus Probst
2026-03-09 13:32 ` Danilo Krummrich
2026-03-09 13:38 ` Markus Probst
2026-03-09 15:15 ` Lee Jones
2026-03-09 15:20 ` Markus Probst
2026-03-09 15:27 ` Lee Jones
2026-03-09 15:37 ` Danilo Krummrich
2026-03-09 15:50 ` Lee Jones
2026-03-08 18:56 ` Greg Kroah-Hartman
2026-03-08 19:23 ` Markus Probst
2026-03-09 5:55 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33efd44c-be12-468c-9505-ff0d7b66b701@kernel.org \
--to=krzk@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox