From: Timur Tabi <ttabi@nvidia.com>
To: Zhi Wang <zhiw@nvidia.com>, John Hubbard <jhubbard@nvidia.com>,
"gary@garyguo.net" <gary@garyguo.net>,
"nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
Eliot Courtney <ecourtney@nvidia.com>,
"russ.weight@linux.dev" <russ.weight@linux.dev>,
"dakr@kernel.org" <dakr@kernel.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"driver-core@lists.linux.dev" <driver-core@lists.linux.dev>,
Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH v4 1/7] rust: firmware: add request_into_buf()
Date: Thu, 9 Jul 2026 22:46:25 +0000 [thread overview]
Message-ID: <3449b6a458c3c95041a51281ea4bca8964ee0dd6.camel@nvidia.com> (raw)
In-Reply-To: <20260709213915.520109-2-ttabi@nvidia.com>
On Thu, 2026-07-09 at 16:39 -0500, Timur Tabi wrote:
> - error::Error,
> - error::Result,
> + error::*,
...
> + if buf.is_empty() {
> + return Err(crate::error::code::EINVAL);
> + }
Sorry, I just noticed that this is wrong. I'll fix it in v5.
next prev parent reply other threads:[~2026-07-09 22:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 21:39 [PATCH v4 0/7] Transition Nova Core to TLV firmare images Timur Tabi
2026-07-09 21:39 ` [PATCH v4 1/7] rust: firmware: add request_into_buf() Timur Tabi
2026-07-09 22:46 ` Timur Tabi [this message]
2026-07-09 23:02 ` Danilo Krummrich
2026-07-09 21:39 ` [PATCH v4 2/7] gpu: nova-core: add TLV parser for firmware files Timur Tabi
2026-07-09 21:39 ` [PATCH v4 3/7] gpu: nova-core: transition booter_load to TLV images Timur Tabi
2026-07-09 21:39 ` [PATCH v4 4/7] gpu: nova-core: transition gsp " Timur Tabi
2026-07-09 23:21 ` Danilo Krummrich
2026-07-09 21:39 ` [PATCH v4 5/7] gpu: nova-core: transition gen_bootloader " Timur Tabi
2026-07-09 21:39 ` [PATCH v4 6/7] gpu: nova-core: transition fsp " Timur Tabi
2026-07-09 21:39 ` [PATCH v4 7/7] gpu: nova-core: update firmware module info for " Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3449b6a458c3c95041a51281ea4bca8964ee0dd6.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=mcgrof@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox