From: Timur Tabi <ttabi@nvidia.com>
To: "dakr@kernel.org" <dakr@kernel.org>, John Hubbard <jhubbard@nvidia.com>
Cc: "lossin@kernel.org" <lossin@kernel.org>,
"a.hindborg@kernel.org" <a.hindborg@kernel.org>,
"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
Zhi Wang <zhiw@nvidia.com>, "simona@ffwll.ch" <simona@ffwll.ch>,
"tmgross@umich.edu" <tmgross@umich.edu>,
"alex.gaynor@gmail.com" <alex.gaynor@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
"bjorn3_gh@protonmail.com" <bjorn3_gh@protonmail.com>,
Edwin Peer <epeer@nvidia.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
Alexandre Courbot <acourbot@nvidia.com>,
"gary@garyguo.net" <gary@garyguo.net>,
Alistair Popple <apopple@nvidia.com>
Subject: Re: [PATCH v3 2/2] gpu: nova-core: add boot42 support for next-gen GPUs
Date: Thu, 30 Oct 2025 01:44:28 +0000 [thread overview]
Message-ID: <35c2d37d02409be8fea5acd713832da938966c43.camel@nvidia.com> (raw)
In-Reply-To: <b8796ee0-05fc-48e1-a075-2bad99b938d2@nvidia.com>
On Wed, 2025-10-29 at 18:07 -0700, John Hubbard wrote:
> Yes, but someone can still plug in a pre-Turing GPU and try to
> boot up with nova-core.ko on the system.
>
> So it's important to avoid getting into trouble in that case.
Sure, but I think we don't want any real code that looks at boot0. Nova should really just look
at boot42 to determine any architecture. So what we really want is to avoid accidentally
reading boot42 on GPUs where it doesn't exist. I believe that the oldest GPU that supports
boot42 is Fermi GF100, or chipset id 0x0c0. So we can do something like this:
fn is_gpu_ancient(bar: &Bar0) -> bool {
let boot0 = regs::NV_PMC_BOOT_0::read(bar);
if boot0.architecture_1() == 0 && boot0.architecture_0() < 0x0c0 {
return true;
} else {
return false;
}
At the beginning of probe(), if is_gpu_ancient() returns true, just exit immediately. Then the
rest of the driver can happily ignore boot0 completely and use boot42 for everything.
Just my two cents.
next prev parent reply other threads:[~2025-10-30 1:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 3:03 [PATCH v3 0/2] gpu: nova: add boot42 support for next-gen GPUs John Hubbard
2025-10-29 3:03 ` [PATCH v3 1/2] gpu: nova-core: prepare Spec and Revision types for boot0/boot42 John Hubbard
2025-10-29 3:03 ` [PATCH v3 2/2] gpu: nova-core: add boot42 support for next-gen GPUs John Hubbard
2025-10-29 11:26 ` Danilo Krummrich
2025-10-29 13:54 ` Alexandre Courbot
2025-10-30 0:37 ` John Hubbard
2025-10-30 0:54 ` Alexandre Courbot
2025-10-30 1:09 ` John Hubbard
2025-10-30 0:29 ` John Hubbard
2025-10-30 0:31 ` Timur Tabi
2025-10-30 0:35 ` John Hubbard
2025-10-30 1:01 ` Timur Tabi
2025-10-30 1:07 ` John Hubbard
2025-10-30 1:13 ` John Hubbard
2025-10-30 1:44 ` Timur Tabi [this message]
2025-10-30 5:30 ` John Hubbard
2025-10-30 14:22 ` Timur Tabi
2025-10-30 14:45 ` Danilo Krummrich
2025-10-29 14:05 ` Alexandre Courbot
2025-10-31 0:04 ` John Hubbard
2025-11-02 0:34 ` John Hubbard
2025-11-02 2:41 ` Alexandre Courbot
2025-11-02 3:33 ` John Hubbard
2025-11-08 1:55 ` Alexandre Courbot
2025-11-08 2:03 ` John Hubbard
2025-10-29 15:02 ` Timur Tabi
2025-10-29 23:15 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c2d37d02409be8fea5acd713832da938966c43.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).