* [PATCH] rust: fix bindgen build error with UBSAN_BOUNDS_STRICT
@ 2023-07-11 7:19 Andrea Righi
2023-07-11 15:31 ` Martin Rodriguez Reboredo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andrea Righi @ 2023-07-11 7:19 UTC (permalink / raw)
To: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho
Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
Kees Cook, rust-for-linux, linux-kernel
With commit 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS on GCC") if
CONFIG_UBSAN is enabled and gcc supports -fsanitize=bounds-strict, we
can trigger the following build error due to bindgen lacking support for
this additional build option:
BINDGEN rust/bindings/bindings_generated.rs
error: unsupported argument 'bounds-strict' to option '-fsanitize='
Fix by adding -fsanitize=bounds-strict to the list of skipped gcc flags
for bindgen.
Fixes: 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS on GCC")
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
---
rust/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/Makefile b/rust/Makefile
index 7c9d9f11aec5..4124bfa01798 100644
--- a/rust/Makefile
+++ b/rust/Makefile
@@ -257,7 +257,7 @@ bindgen_skip_c_flags := -mno-fp-ret-in-387 -mpreferred-stack-boundary=% \
-fno-partial-inlining -fplugin-arg-arm_ssp_per_task_plugin-% \
-fno-reorder-blocks -fno-allow-store-data-races -fasan-shadow-offset=% \
-fzero-call-used-regs=% -fno-stack-clash-protection \
- -fno-inline-functions-called-once \
+ -fno-inline-functions-called-once -fsanitize=bounds-strict \
--param=% --param asan-%
# Derived from `scripts/Makefile.clang`.
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] rust: fix bindgen build error with UBSAN_BOUNDS_STRICT
2023-07-11 7:19 [PATCH] rust: fix bindgen build error with UBSAN_BOUNDS_STRICT Andrea Righi
@ 2023-07-11 15:31 ` Martin Rodriguez Reboredo
2023-07-11 16:11 ` Kees Cook
2023-08-02 17:37 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Martin Rodriguez Reboredo @ 2023-07-11 15:31 UTC (permalink / raw)
To: Andrea Righi, Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho
Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
Kees Cook, rust-for-linux, linux-kernel
On 7/11/23 04:19, Andrea Righi wrote:
> With commit 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS on GCC") if
> CONFIG_UBSAN is enabled and gcc supports -fsanitize=bounds-strict, we
> can trigger the following build error due to bindgen lacking support for
> this additional build option:
>
> BINDGEN rust/bindings/bindings_generated.rs
> error: unsupported argument 'bounds-strict' to option '-fsanitize='
>
> Fix by adding -fsanitize=bounds-strict to the list of skipped gcc flags
> for bindgen.
>
> Fixes: 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS on GCC")
> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
> ---
> [...]
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rust: fix bindgen build error with UBSAN_BOUNDS_STRICT
2023-07-11 7:19 [PATCH] rust: fix bindgen build error with UBSAN_BOUNDS_STRICT Andrea Righi
2023-07-11 15:31 ` Martin Rodriguez Reboredo
@ 2023-07-11 16:11 ` Kees Cook
2023-08-02 17:37 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2023-07-11 16:11 UTC (permalink / raw)
To: Andrea Righi
Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, rust-for-linux,
linux-kernel
On Tue, Jul 11, 2023 at 09:19:14AM +0200, Andrea Righi wrote:
> With commit 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS on GCC") if
> CONFIG_UBSAN is enabled and gcc supports -fsanitize=bounds-strict, we
> can trigger the following build error due to bindgen lacking support for
> this additional build option:
>
> BINDGEN rust/bindings/bindings_generated.rs
> error: unsupported argument 'bounds-strict' to option '-fsanitize='
>
> Fix by adding -fsanitize=bounds-strict to the list of skipped gcc flags
> for bindgen.
>
> Fixes: 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS on GCC")
> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Thanks for catching this!
Acked-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rust: fix bindgen build error with UBSAN_BOUNDS_STRICT
2023-07-11 7:19 [PATCH] rust: fix bindgen build error with UBSAN_BOUNDS_STRICT Andrea Righi
2023-07-11 15:31 ` Martin Rodriguez Reboredo
2023-07-11 16:11 ` Kees Cook
@ 2023-08-02 17:37 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2023-08-02 17:37 UTC (permalink / raw)
To: Andrea Righi
Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Kees Cook,
rust-for-linux, linux-kernel
On Tue, Jul 11, 2023 at 9:19 AM Andrea Righi <andrea.righi@canonical.com> wrote:
>
> With commit 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS on GCC") if
> CONFIG_UBSAN is enabled and gcc supports -fsanitize=bounds-strict, we
> can trigger the following build error due to bindgen lacking support for
> this additional build option:
>
> BINDGEN rust/bindings/bindings_generated.rs
> error: unsupported argument 'bounds-strict' to option '-fsanitize='
>
> Fix by adding -fsanitize=bounds-strict to the list of skipped gcc flags
> for bindgen.
>
> Fixes: 2d47c6956ab3 ("ubsan: Tighten UBSAN_BOUNDS on GCC")
> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Applied to `rust-fixes`, thanks!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-02 17:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-11 7:19 [PATCH] rust: fix bindgen build error with UBSAN_BOUNDS_STRICT Andrea Righi
2023-07-11 15:31 ` Martin Rodriguez Reboredo
2023-07-11 16:11 ` Kees Cook
2023-08-02 17:37 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).