Rust for Linux List
 help / color / mirror / Atom feed
From: Timur Tabi <ttabi@nvidia.com>
To: John Hubbard <jhubbard@nvidia.com>,
	Eliot Courtney <ecourtney@nvidia.com>,
	"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
	Zhi Wang <zhiw@nvidia.com>, "gary@garyguo.net" <gary@garyguo.net>,
	"nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
	"dakr@kernel.org" <dakr@kernel.org>,
	"mcgrof@kernel.org" <mcgrof@kernel.org>,
	Alexandre Courbot <acourbot@nvidia.com>,
	"driver-core@lists.linux.dev" <driver-core@lists.linux.dev>,
	"russ.weight@linux.dev" <russ.weight@linux.dev>,
	"ojeda@kernel.org" <ojeda@kernel.org>
Subject: Re: [PATCH v3 2/7] gpu: nova-core: add TLV parser for firmware files
Date: Thu, 2 Jul 2026 19:45:35 +0000	[thread overview]
Message-ID: <3e771bfc6b0c89afc7969755e340a5fa863bc7cc.camel@nvidia.com> (raw)
In-Reply-To: <20260702192712.3450652-3-ttabi@nvidia.com>

On Thu, 2026-07-02 at 14:27 -0500, Timur Tabi wrote:
> +    pub(crate) fn get_bytes(&self, tag: &[u8; 4]) -> Result<&'a [u8]> {
> +        let tlv = self.find(tag)?;
> +
> +        Ok(tlv.value)
> +    }

I forgot to update get_bytes() to return an error if the value is empty.  That should address a lot
of potential issues, including the ones that Sashiko raised.

  reply	other threads:[~2026-07-02 19:45 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02 19:27 [PATCH v3 0/7] Transition Nova Core to TLV firmare images Timur Tabi
2026-07-02 19:27 ` [PATCH v3 1/7] rust: firmware: add request_into_buf() Timur Tabi
2026-07-03  2:51   ` Alvin Sun
2026-07-03  3:06     ` Timur Tabi
2026-07-03 13:51       ` Danilo Krummrich
2026-07-06  6:30   ` Alexandre Courbot
2026-07-06 10:50     ` Danilo Krummrich
2026-07-07  2:54       ` Timur Tabi
2026-07-07  5:10         ` Alexandre Courbot
2026-07-07 13:32           ` Danilo Krummrich
2026-07-02 19:27 ` [PATCH v3 2/7] gpu: nova-core: add TLV parser for firmware files Timur Tabi
2026-07-02 19:45   ` Timur Tabi [this message]
2026-07-06  6:31     ` Alexandre Courbot
2026-07-07  2:56       ` Timur Tabi
2026-07-07  5:13         ` Alexandre Courbot
2026-07-08 22:48           ` Timur Tabi
2026-07-09  3:43             ` Alexandre Courbot
2026-07-09 21:29               ` Timur Tabi
2026-07-06  6:31   ` Alexandre Courbot
2026-07-08 20:12     ` Timur Tabi
2026-07-09  1:55       ` Alexandre Courbot
2026-07-02 19:27 ` [PATCH v3 3/7] gpu: nova-core: transition booter_load to TLV images Timur Tabi
2026-07-06  6:31   ` Alexandre Courbot
2026-07-08 20:46     ` Timur Tabi
2026-07-09  3:51       ` Alexandre Courbot
2026-07-09 21:31         ` Timur Tabi
2026-07-02 19:27 ` [PATCH v3 4/7] gpu: nova-core: transition gsp " Timur Tabi
2026-07-02 19:27 ` [PATCH v3 5/7] gpu: nova-core: transition gen_bootloader " Timur Tabi
2026-07-06  6:31   ` Alexandre Courbot
2026-07-08 22:26     ` Timur Tabi
2026-07-09  2:24       ` Alexandre Courbot
2026-07-09 21:27         ` Timur Tabi
2026-07-09 21:49           ` John Hubbard
2026-07-09 22:13             ` Timur Tabi
2026-07-09 22:29               ` John Hubbard
2026-07-09 22:39                 ` Timur Tabi
2026-07-09 22:41                   ` John Hubbard
2026-07-09 22:44                     ` Timur Tabi
2026-07-02 19:27 ` [PATCH v3 6/7] gpu: nova-core: transition fsp " Timur Tabi
2026-07-02 19:27 ` [PATCH v3 7/7] gpu: nova-core: update firmware module info for " Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e771bfc6b0c89afc7969755e340a5fa863bc7cc.camel@nvidia.com \
    --to=ttabi@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=ecourtney@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=mcgrof@kernel.org \
    --cc=nova-gpu@lists.linux.dev \
    --cc=ojeda@kernel.org \
    --cc=russ.weight@linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox