Re: [PATCH v8] rust: add new macro for common bitflag operations

[Filipe Xavier <felipeaggger@gmail.com>]

On 1/11/26 5:06 PM, Miguel Ojeda wrote:

> On Sun, Jan 11, 2026 at 2:33 PM Filipe Xavier <felipeaggger@gmail.com> wrote:
>> +// SPDX-License-Identifier: GPL-2.0
>> +
>> +//! Common helper for declaring bitflag and bitmask types.
>> +///
>> +/// This macro takes as input:
> So I didn't mean to convert the first line to `//!`, but to add
> documentation to the module between the SPDX line and the
> documentation for the item.

Oh, sorry, I misunderstood. I thought it might be redundant; I'll adjust 
it in the next version.

> Please see how other files do it, e.g. `rust/kernel/slice.rs` and
> `rust/kernel/irq.rs` are similar cases (no `use` blocks between `//!`
> and the first item).
>
> But please wait a few days in case there is any other feedback --
> hopefully we are getting finally there.
>
> (By the way, in general, it is good to reply to the feedback messages
> you get, to confirm or not whether you applied a particular
> suggestion).
>
> Thanks for updating the docs and being persistent!
I am the one who is grateful for the feedback and patience.

Xavier